Add script to copy the Run 2 MC TriggerDB to SQLite

The new script AtlTriggerDBCopy.py can be used to copy the Oracle MC TriggerDB of Run2 to SQLite. This is part of the work of the Containerization Task force.

The script will not run within athena, but only be executed by hand on occasion

added Trigger master labels

This merge request affects 1 package:

• Trigger/TrigConfiguration/TrigConfIO

Adding @mark ,@orlando ,@cmorenom ,@asonay as watchers

added review-pending-level-1 label

Hi @stelzer

Thanks for this, looks nice that can easily slim the selection of tables to really be left with what is needed for MC.

As this doesn't need Athena and is really for legacy is master really the best place for this? I see it's so you can use ConfigDBLoader but there must be alternatives? I was thinking of the TrigDb package if possible to be in sync with where the schema was for these DBs, but know this isn't ideal given that is java.

I would choose a more accurate name (partially to avoid future needs for copy scripts) - how about Run2TriggerDBToSqlite.py?

Have you confirmed that running with a key gives a similar output from the sqlite copy to that of running from the DB itself - if so do you have an example of how to quickly confirm this so we can document it.

Thanks again, Mark

Hi @mark

my plan was to also make sure one can use this script for Run 3 (at least initially for people to work with), there are switches inside that allows you to have different exclusion lists. The name was chosen to match AtlCoolCopy, but it doesn't have to be.

I would think master is fine, I wouldn't put it in tdaq though. There is no need to sync this as the old TriggerDB is frozen. But I leave this to you, just tell me where you would like to have this.

I've checked that the entries are there. The validation of running from sqlite in the container will be done by the task force.

Cheers, Joerg

CI Result SUCCESS (hash 9411c944)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20588]

Even though this won't run inside of Athena, passing to L2 to review this new script.

added review-pending-level-2 label and removed review-pending-level-1 label

In the mean time, there's also a related build warning

""" scripts/AtlTriggerDBCopy.py:9:1: warning: F401 'cx_Oracle' imported but unused """

added review-user-action-required label

Just one line to be inserted for better readability, otherwise I have no additional comments. The code is well written.

Cheers,

Michele, L2 reviewer

removed review-pending-level-2 label

added 1 commit

• 9b8a1080 - Address comments from review

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Trigger/TrigConfiguration/TrigConfIO

Adding @mark ,@orlando ,@cmorenom ,@asonay as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 9b8a1080)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20631]

Changes look good, approving.

Xiaozhong (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c2aca4b3

added sweep:ignore label

mentioned in merge request !36807 (merged)

mentioned in merge request !38264 (merged)