TriggerJobOpts+TrigEDMConfig: Improve configuration of writing Run-3 HLT Navigation to output

Move the functionality of adding HLT Navigation to EDM list for output writing from TriggerConfig to TrigEDMConfig. This reduces boilerplate code and makes it easier to find and update the configuration. The logic is now defined in one place only and it's independent of the output type. The target output types for HLT Navigation are now defined in the same place and with the same format as all other EDM collections. This is particularly useful when adding/removing targets (e.g. the recent addition of the navigation to CostMonDS output in !35881 (merged)).

Tested with test_trigP1_v1Dev_decodeBS_build.py, test_trigP1_v1PhysP1_T0Mon_build.py and test_trigAna_RDOtoT0Mon_mt1_build.py. I see the HLTNav collections in both full and cost mon outputs, and the offline monitoring didn't complain.

cc @tamartin

This merge request affects 2 packages:

• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerJobOpts

Adding @sutt ,@okuprash ,@bernius as watchers

added Trigger TriggerEDM master review-pending-level-1 labels

Ok, I'm actually not 100% sure about offline monitoring not complaining - worked for me on data but had some problem on MC. Could be unrelated though, let's see what CI says (should be tested in the DQ CI test).

CI Result FAILURE (hash 6d54c833)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20630]

Hmm so I did break something...

L2MuonSAMonMT_H...  ERROR TrigMuonMonitoringMT/src/L2MuonSAMonMT.cxx:26 (StatusCode L2MuonSAMonMT::fillVariablesPerChain(const EventContext&, const std::string&) const): code FAILURE: muLinkInfo.isValid()

@tamartin, would you have any ideas? I see plenty of HLTNav collections in the AOD.pool.root.checkxAOD file from test_trigAna_RDOtoT0Mon_mt1_build.py but the same failure in the monitoring

added 1 commit

• ef612109 - Add HLTNav dynamic variables to EDM explicitly

Compare with previous version

This merge request affects 2 packages:

• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerJobOpts

Adding @sutt ,@okuprash ,@bernius as watchers

resolved all threads

CI Result SUCCESS (hash ef612109)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 4
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 20654]

Warnings are unrelated, approving. L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d0011661

added sweep:ignore label