preInclude file of fractionally charged particles

Merge request for the preInclude file of fractionally charged particles.

added 21.0 label

This merge request affects 1 package:

• Simulation/SimulationJobOptions

Adding @jchapman ,@vpascuzz as watchers

added Simulation review-pending-level-1 labels

CI Result SUCCESS (hash 723e7c97)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 161
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44835]

I added a few comments, passing back to the user. Cheers, Michele (L1 reviewer)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• e55818d5 - Modification based on comments from experts

Compare with previous version

Modification has been done based on the comments from @mfauccig .

This merge request affects 1 package:

• Simulation/SimulationJobOptions

Adding @jchapman ,@vpascuzz as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash e55818d5)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44845]

resolved all threads

Thanks for considering and implementing my suggestion. Approving now. Cheers, Michele (L1 reviewer)

added review-approved label and removed review-pending-level-1 label

Thank you! So this file will appear from release 21.0.118? How long will it take?

Hi @rmazini,
Could you comment on the schedule for building 21.0.118 please?
Cheers,
John

Hello @jchapman If there is an urgent request for 21.0.118 I can build it after the next nightly validations, probably by the end of the week But I need a clear request from you guys. Cheers, Rachid

Hi @rmazini , if you can build 21.0.118 by the end of this week or the beginning of next week, it will be in time for us. I will also summarize our JOs and submit to the jira ticket by the end of this week. If everything is smooth, our MC sample could be submitted to the grid in the next week. Thank you!

added 1 commit

• 7a16a3af - type error modification in print

Compare with previous version

This merge request affects 1 package:

• Simulation/SimulationJobOptions

Adding @jchapman ,@vpascuzz as watchers

added review-pending-level-1 label and removed review-approved label

Hi @mfauccig and @rmazini , I just found a a bug during the modification according to the suggestion from Michele. Now the bug is fixed and we need to merge the file again. Thank you!

CI Result SUCCESS (hash 7a16a3af)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44869]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4daf7629

added sweep:done label

picked the changes into the branch cherry-pick-4daf7629847-master with commit e24faf7f

mentioned in commit e24faf7f

mentioned in merge request !36707 (merged)

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1289/console for details)

mentioned in commit 7036156e

mentioned in merge request !36772 (merged)

mentioned in commit d71b36ab