Add intial ITk flags implementation, and use to steer loading of local Geometry XML files

Adding an example of how ITk ComponentAccumulator flags could work for demonstration/discussion

The example here is for toggling the source of Geometry Description Xml between local and from the DDDB.

cc @tstreble @ncalace @hhayward @tlari @asalzbur @ssevova @sroe @goetz

There are some discussions ongoing about how/where other properties should be toggled for ITk (i.e. whether to have a completely parallel and separate configuration or share common parts with InDet) but I think this one is a clear case for only being present for ITk?

I'll therefore move this out of WIP.

unmarked as a Work In Progress

This merge request affects 3 packages:

• Control/AthenaConfiguration
• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/StripGeoModelXml

Adding @goetz ,@sroe ,@ssnyder as watchers

added Core InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 0106cc55)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21507]

Please address the error "RuntimeError: No such flag: InDet.Tracking.minPt The name is likely incomplete". (L1)

added review-user-action-required label and removed review-pending-level-1 label

I think this test failure might be coming from elsewhere, not from the changes here? I saw the following when running the test locally on AthenaConfiguration and InDetConfig as they are in the latest master nightly and I see:

[nstyles@lxplus783]/tmp/nstyles/new/build% make test
Running tests...
Test project /tmp/nstyles/new/build
    Start 1: AthenaConfiguration_ComponentAccumulatorTest_ctest
1/8 Test #1: AthenaConfiguration_ComponentAccumulatorTest_ctest .......   Passed    2.03 sec
    Start 2: AthenaConfiguration_UnifyPropertiesTest_ctest
2/8 Test #2: AthenaConfiguration_UnifyPropertiesTest_ctest ............   Passed    1.33 sec
    Start 3: AthenaConfiguration_AthConfigFlagsTest_ctest
3/8 Test #3: AthenaConfiguration_AthConfigFlagsTest_ctest .............   Passed    1.37 sec
    Start 4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest
4/8 Test #4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest ...   Passed    8.10 sec
    Start 5: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest
5/8 Test #5: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest ...   Passed    7.19 sec
    Start 6: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest
6/8 Test #6: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest ....   Passed   22.36 sec
    Start 7: AthenaConfiguration_AllConfigFlagsTest_ctest
7/8 Test #7: AthenaConfiguration_AllConfigFlagsTest_ctest .............***Failed   62.67 sec
    Start 8: InDetConfig_TrackingCutsFlags_test_ctest
8/8 Test #8: InDetConfig_TrackingCutsFlags_test_ctest .................   Passed    6.38 sec

This doesn't happen when using my master-addITkConfigFlags branch, but I think that is because there have been updates to InDetConfig since I created my branch.

In fact, I think it is due to the update in !36715 (merged) here where there appear to be a typo (I think the unit test didn't catch it because only InDetConfig was updated there, while it is actually AllConfigFlagsTest_ctest which catches the problem).

added 1163 commits

• 0106cc55...ea3e6642 - 1160 commits from branch atlas:master
• 313262a9 - Add intial ITk flags implementation, and use to steer loading of local Geometry XML files
• 23e6c777 - fix typo in cut definition
• 5e80feb4 - Merge branch 'master-addITkConfigFlags' of...

Compare with previous version

This merge request affects 3 packages:

• Control/AthenaConfiguration
• InnerDetector/InDetConfig
• InnerDetector/InDetDetDescr/StripGeoModelXml

Adding @goetz ,@sroe ,@ssnyder as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 5e80feb4)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21542]

CI passed now, approving.

added review-approved label and removed review-pending-level-1 label

Should fix also ATLASRECTS-5682

merged

mentioned in commit 3bcd194a

added sweep:ignore label