METReconstruction: fix to METAssociator to fix difference between serial and MT running

This MR fixes the behaviour here identified here ATLASRECTS-5587 and moves to declaring the PFO container ReadHandleKey as a property in the header file. The code should probably be changed so that the ClusterContainer and TrackContainer keys are declared similarly, but I will leave this for a future MR.

This merge request affects 2 packages:

• Reconstruction/MET/METReconstruction
• Reconstruction/RecExample/RecExRecoTest

Adding @goetz as watcher

added JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash 4279e1a7)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21184]

There is a warning about thread safety but I am not sure why since the METTruthAssociator class was touched (maybe it derives from one of the classes added to the in the new file?). Here is the warning:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/MET/METReconstruction/Root/METTruthAssociator.cxx:176:38: warning: 'static' expression 'met::cacc_ghosttruth' of type 'SG::AuxElement::ConstAccessor<std::vector<ElementLink<DataVector<xAOD::IParticle> > > >' passed to pointer or reference function argument of 'SG::AuxElement::ConstAccessor<std::vector<ElementLink<DataVector<xAOD::IParticle> > > >::isAvailable' within function 'StatusCode met::METTruthAssociator::associateJets(xAOD::MissingETAssociationMap*) const'; may not be thread-safe
       if(!cacc_ghosttruth.isAvailable(*jet)) {
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

I also had minor comments.

Cheers,

Michele (L1 reviewer)

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 06c0e394 - Updating dates in METAssociator, removing unnecessary line in MET ART test

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/MET/METReconstruction
• Reconstruction/RecExample/RecExRecoTest

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 06c0e394)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21221]

added review-pending-level-2 label and removed review-pending-level-1 label

changed the description

added review-user-action-required label

added 206 commits

• 06c0e394...0f40f13d - 204 commits from branch atlas:master
• 954fccd1 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into METAssocFixSept2020
• 5e34aa3c - Removing thread safety checks to get MR in

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/MET/METReconstruction
• Reconstruction/RecExample/RecExRecoTest

Adding @goetz as watcher

added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

CI Result SUCCESS (hash 5e34aa3c)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21473]

CI looks ok now, passing to L2 again to check if all previous comments were addressed.

Cheers, Volker (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

resolved all threads

Looks fine to me now, so approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 87b59807

added sweep:ignore label