Skip to content
Snippets Groups Projects

Add pixel clustering number network lwtnn implementation in r22

Merged Sebastien Rettie requested to merge srettie/athena:master-srettie_NNdev into master
All threads resolved!

Following up on @kpachal's implementation of lwtnn for the position networks here, this implements a similar functionality for the number network.

Tagging @gfacini, @battagl, @npetters, @vcairo, @goblirsc, for info.

Edited by Sebastien Rettie

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS (hash f3d39ebb)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21273]

  • hi @srettie , back to user since there are unresolved threads.

    cheers, Santiago (L1)

  • Sebastien Rettie added 263 commits

    added 263 commits

    • f3d39ebb...ea3e6642 - 261 commits from branch atlas:master
    • ad8c4481 - Add proper error statements
    • 1f74a1ce - Merge remote-tracking branch 'upstream/master' into master-srettie_NNdev

    Compare with previous version

  • :pencil: :pushpin: build area is cleaned as the previous build was for the MR labeled as full-build

  • This merge request affects 1 package:

    • InnerDetector/InDetRecTools/SiClusterizationTool

    Adding @goetz ,@oda ,@amorley ,@sroe as watchers

  • :white_check_mark: CI Result SUCCESS (hash 1f74a1ce)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21541]

  • Still one unresolved thread - sending back to user.

  • Sebastien Rettie resolved all threads

    resolved all threads

  • Sebastien Rettie resolved all threads

    resolved all threads

  • Sebastien Rettie resolved all threads

    resolved all threads

  • Hi @dgil,

    I had forgotten to resolve the thread, sorry about that! I've resolved them now, so please feel free to proceed with the review.

    Cheers.

    Sébastien.

  • Sebastien Rettie resolved all threads

    resolved all threads

  • No problem, thanks.

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit caf17486

  • Please register or sign in to reply
    Loading