Let MdtIdHelper return the correct tubeMax

Hi,

previously, the tubeMax method of the MdtIdHelper just returned a hard-coded 78. Now, it is returning maximum value present in the IdDictParser xml.

Best, Nico

WARNING: big files (>100K) are found in the changeset

192K in file MuonSpectrometer/MuonIdHelpers/share/muon_id_test.ref

This merge request affects 9 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• MuonSpectrometer/MuonDigitization/MDT_Digitization
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModelTest
• MuonSpectrometer/MuonIdHelpers
• MuonSpectrometer/MuonSimEvent
• MuonSpectrometer/MuonValidation/MuonPRDTest
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz ,@nkoehler ,@rbianchi as watchers

added Digitization Geometry MuonSpectrometer Simulation master review-pending-level-1 labels

added alsoTargeting:21.3 alsoTargeting:21.9 labels and removed Digitization Geometry MuonSpectrometer Simulation master review-pending-level-1 labels

added 1 commit

• ae27d21f - fix comment

Compare with previous version

WARNING: big files (>100K) are found in the changeset

192K in file MuonSpectrometer/MuonIdHelpers/share/muon_id_test.ref

This merge request affects 9 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• MuonSpectrometer/MuonDigitization/MDT_Digitization
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModelTest
• MuonSpectrometer/MuonIdHelpers
• MuonSpectrometer/MuonSimEvent
• MuonSpectrometer/MuonValidation/MuonPRDTest
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz ,@nkoehler ,@rbianchi as watchers

added Digitization Geometry MuonSpectrometer Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash a7025348)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21302]

CI Result SUCCESS (hash ae27d21f)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21304]

added review-approved label and removed review-pending-level-1 label

mentioned in commit 3da4b94f

merged

Has this broken compilation? See failure on !36924 (merged)

OK looks like s_mdtID was removed in !36871 (merged).

Please advise immediately if you are going to repair it. If I don't hear anything I will be reverting this so we have a working build over the weekend.

mentioned in merge request !36935 (merged)

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• 21.3
• 21.9

resolved all threads

mentioned in merge request !37030 (merged)

The automatic sweeps into 21.3 and 21.9 failed. The changes of this MR were swept manually in !37030 (merged). Thus, removing sweep:failed label

removed sweep:failed label

mentioned in commit 635ba7c6

mentioned in commit 0e4ab61a

mentioned in merge request !37128 (merged)

mentioned in commit c9450f83

mentioned in merge request !37305 (merged)

mentioned in commit 5ea3d5dc