Additions to InDetPhysValMonitoring

This MR combines three changes to InDetPhysValMonitoring:

• A standalone job option file, based on run/PhysVal_jopOptions.py, is put into share, allowing it to be installed into the athena job option search path. This standalone setup can be configured using command line arguments using the AthArgParser, avoiding the need to hack job option files
• A segfault in the vertexing plots when encountering an empty truth vertex collection is caught
• Additional plots of the hits on track for fakes and unlinked tracks are added to the expert-level output

Adding @sroe and @npetters as well as @gfacini who may find this useful for CTIDE tuning.

added Tracking master labels

added 5 commits

• a30a0ecf - revise standalone IDPVM job options to re-use existing code
• 067cc689 - extend track-in-jet plots to prepare truth matched versions without effi booking
• 010f0f59 - extend RTTPlots to book additional track-in-jet plots
• dfa71bbf - fix logic inconsistency for jet plots and support filling of extra jet plots
• 8e9cca14 - fix one flag to avoid blocking expert output

Compare with previous version

added 1 commit

• 5470260f - change jet track dir

Compare with previous version

unmarked as a Work In Progress

This merge request affects 1 package:

• InnerDetector/InDetValidation/InDetPhysValMonitoring

Adding @goetz ,@sroe as watchers

added InnerDetector review-pending-level-1 labels

CI Result SUCCESS (hash 5470260f)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21410]

avoiding the need to hack job option files

Depends on what You mean by hacking jobOptions. There is no need to modify existing job options, since You can adjust all flags, properties etc. via preExec, postExec (e.g test_ele10GeV_reco.sh ), or if You want to reuse complex settings, they can be stored in python snippets loaded via preInclude and postInclude. The standalone job options have the disadvantage that they have to be maintained, which is typically not done and that is why there are zillions of broken job options. Maybe the latter becomes better with new jobOptions. Also arguments are never flexible enough. That is why despite Reco_tf having several pages of arguments, for most customization preExecs etc. are still needed.

My 2 cents, Götz

Hi @goetz ,

this comment was referring specifically to standalone job options, where the existing version in 'run' (and in 21.9) requires editing the file itself to effect configuration.

The standalone JO are intended for quick local running, in particular on ESD, where the power but also overhead of Reco_tf (which schedules an additional ESDtoAOD in this case) is not needed.

They specifically address the use case of tracking development on a local machine where the (potentially new and inexperienced with IDPVM) user wants to quickly run and check around 100 events in a basic setup after making a change, but is not familiar with the flags available or the details of how to configure Reco_tf and how to lookup all the arguments and flags.

For any more in-depth or production / validation use, Reco_tf is obviously still the way to go, and I don't intend for the standalone JO to support more than the handfuls of args it provides now.

Cheers,Max

Hi @goblirsc,

I only have to very minor comments, but I would also be fine with approving this without changes. Please let me know.

Cheers, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @vaustrup, thanks for the suggestions, I think they make sense! I pushed changes implementing them - actually, it turns out that isFakeJet is now equivalent to isFake, so I ended up removing the former one altogether and re-using isFake instead. Cheers, Max

added 1 commit

• 9c259611 - clean up fake flag in jet plot filling

Compare with previous version

resolved all threads

This merge request affects 1 package:

• InnerDetector/InDetValidation/InDetPhysValMonitoring

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 9c259611)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21519]

added review-approved label and removed review-pending-level-1 label

The changes look good and the CI test passes. Approving (L1)

merged

mentioned in commit 0a1f7dfd

added sweep:ignore label