Add new ML tests for TrigInDetValidation ART tests

Add ML tests for beamspot_zfinder, tau and jet

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

added 21.3 Trigger review-pending-level-1 labels

CI Result SUCCESS (hash 08aa044e)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44933]

hi @hartj I added trivial comments to address, however I'm escalating to L2 since I don't fully understand the impact of the added code of the .sh files.

Cheers, Santiago (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added 1 commit

• 5ecb6bd8 - add copyright

Compare with previous version

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

resolved all threads

CI Result SUCCESS (hash 5ecb6bd8)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 157
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44938]

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

CI Result SUCCESS (hash 5ecb6bd8)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 157
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44948]

Hi @jchapman , Do you know what the problem is here. The original CI was successful and all I added was the copyright as requested.

Cheers Julie

Jenkins please retry a build

Retrying the build once more

This merge request affects 1 package:

• Trigger/TrigValidation/TrigInDetValidation

Adding @sutt ,@hartj ,@okumura ,@bernius ,@nagano ,@mvozak ,@jpanduro as watchers

These 157 compilation failures aren't due to these changes - the TrigInDetValidation package is only used for the nightly tests, eg

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/ForwardDetectors/AFP/AFP_ByteStream2RawCnv/src/AFP_ByteStream2RawCnv.cxx: In member function 'AFP_SiRawCollection* AFP_ByteStream2RawCnv::getCollectionSi(unsigned int, unsigned int, AFP_RawContainer*)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/ForwardDetectors/AFP/AFP_ByteStream2RawCnv/src/AFP_ByteStream2RawCnv.cxx:210:59: warning: unused parameter 'link' [-Wunused-parameter]
 AFP_ByteStream2RawCnv::getCollectionSi(const unsigned int link, const unsigned int robId,
                                                           ^~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/ForwardDetectors/AFP/AFP_ByteStream2RawCnv/src/AFP_ByteStream2RawCnv.cxx:210:84: warning: unused parameter 'robId' [-Wunused-parameter]
 AFP_ByteStream2RawCnv::getCollectionSi(const unsigned int link, const unsigned int robId,

Since these changes were pretty much exclusively just cosmetic changes to the copyright statement, and we need these tests for the validation, can we just have it merged ? It would seem sub-optimal to have to wait another ~ 8 hours for the release to be built for the CI tests, when these changes don't affect any other packages.

Cheers Mark

CI Result SUCCESS (hash 5ecb6bd8)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 95
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44960]

Hi, since we now have only 95 completely unrelated compilation failures, eg, WARNINGS from, almost exclusively, muon packages, including such favourites as ...

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/sTgcReadoutElement.h: In member function 'bool MuonGM::sTgcReadoutElement::stripGlobalPosition(const Identifier&, Amg::Vector3D&) const':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/sTgcReadoutElement.h:354:9: warning: unused variable 'surfHash_strip' [-Wunused-variable]
     int surfHash_strip = surfaceHash(gasgap, 1);
         ^~~~~~~~~~~~~~

and yet still our package compiles correctly, so I think we can just give up on waiting for the tests to come back successfully, and just merge this one since it won't affect any other packages.

Cheers Mark

Agreed - will approve and merge this one now. (We updated the externals for 21.3 last week, so this caused some CI pipelines to fail.)

Cheers,

John

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit fa2a18b2

Excellent, many thanks John.

Cheers Mark

added sweep:ignore label

mentioned in merge request !37142 (merged)

mentioned in merge request !37305 (merged)

mentioned in commit 5ea3d5dc