add sTGC calib in NSWCalibTool

Adding calibrateStrip function for sTGC

added 1 deleted label

changed target branch from master to 21.3

added 223 commits

• 8f96608d...61d869ae - 222 commits from branch atlas:21.3
• b2d02da9 - Merge branch '21.3' into 'athenaNSW'

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools

Adding @rosati ,@nkoehler ,@wleight as watchers

added 21.3 MuonSpectrometer review-pending-level-1 labels

added alsoTargeting:21.9 label

CI Result SUCCESS (hash b2d02da9)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 100
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44978]

Hi @mcarnesa

The build has generated warnings from multiple packages, the messages are of type: /MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/sTgcReadoutElement.h:354:9: warning: unused variable 'surfHash_strip' [-Wunused-variable] int surfHash_strip = surfaceHash(gasgap, 1);

As far as I can tell, the warnings appear because you include the header file "MuonReadoutGeometry/sTgcReadoutElement.h" in NSWCalibTool.cxx. Could you please take a look at this header file, and try to fix it?

Cheers

Nathan (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi,

indeed we should remove the unused variable from sTgcReadoutElement.h: the modification can be added to this MR.

thanks, cheers, Stefano

added 1 commit

• 3959aee2 - fixing warnings

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

Adding @rosati ,@wleight ,@nkoehler as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• e1cd5699 - fixing warnings

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

Adding @rosati ,@wleight ,@nkoehler as watchers

CI Result SUCCESS (hash 3959aee2)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 100
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44999]

CI Result SUCCESS (hash e1cd5699)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45000]

resolved all threads

Hi @mcarnesa, There are still warning signs by the CI and most of them are as: sTgcReadoutElement.h:353:9: warning: unused variable 'gasgap' [-Wunused-variable]. Could you please have a look into it. Regards, Abhishek (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @abnag,

when you look at the latest CI pipeline (https://bigpanda.cern.ch/compsview/?nightly=MR-CI-builds&rel=MR-37028-2020-10-09-15-04&ar=x86_64-slc6-gcc62-opt&proj=Athena), you see that the remaining compilation warnings are neither in the MuonReadoutGeometry nor the NSWCalibTools package. They are part of the 21.3 nightly.

Best, Nico

added review-pending-level-1 label and removed review-user-action-required label

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3db69a03

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• 21.9
• master

mentioned in commit nkoehler/athena@8f4a794a

mentioned in merge request !37175 (merged)

mentioned in commit nkoehler/athena@30e50843

mentioned in merge request !37176 (merged)

the automatic sweeps into master and 21.9 failed. A manual sweep to master is here: !37175 (merged), to 21.9 here: !37176 (merged). Thus, removing sweep:failed label

removed sweep:failed label

mentioned in commit 842cc8e7

mentioned in commit 3f6e3046

mentioned in commit 9a06f20f

mentioned in commit 640ec53d

mentioned in merge request !37305 (merged)

mentioned in commit 5ea3d5dc