Manual sweep of !36900 (Let MdtIdHelper return the correct tubeMax)

Hi,

since the automatic sweep of !36900 (merged) into 21.3 and 21.9 failed, here the manual sweep.

Best, Nico

added alsoTargeting:21.9 label

mentioned in merge request !36900 (merged)

WARNING: big files (>100K) are found in the changeset

192K in file MuonSpectrometer/MuonIdHelpers/share/muon_id_test.ref

This merge request affects 9 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• MuonSpectrometer/MuonDigitization/MDT_Digitization
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModelTest
• MuonSpectrometer/MuonIdHelpers
• MuonSpectrometer/MuonSimEvent
• MuonSpectrometer/MuonValidation/MuonPRDTest
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS

Adding @jchapman ,@rosati ,@wleight ,@vpascuzz ,@nkoehler ,@rbianchi as watchers

added 21.3 Digitization Geometry MuonSpectrometer Simulation review-pending-level-1 labels

CI Result SUCCESS (hash cf566518)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 99
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44973]

Unused variable warning:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/sTgcReadoutElement.h: In member function 'bool MuonGM::sTgcReadoutElement::stripGlobalPosition(const Identifier&, Amg::Vector3D&) const':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/sTgcReadoutElement.h:354:9: warning: unused variable 'surfHash_strip' [-Wunused-variable]
     int surfHash_strip = surfaceHash(gasgap, 1);
         ^~~~~~~~~~~~~~

This make failure is currenting in the main 21.3 branch, however.

This is a sweep of code, so presumably, the code changes have already been checked once (if not, please kick back). Changes look fairly straight forward. So approving.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 635ba7c6

added sweep:done label

picked the changes into the branch cherry-pick-635ba7c6a85-21.9 with commit 0e4ab61a

mentioned in commit 0e4ab61a

Sweep summary
successful:

• 21.9

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1303/console for details)

mentioned in merge request !37128 (merged)

mentioned in commit c9450f83

mentioned in merge request !37305 (merged)

mentioned in commit 5ea3d5dc