Migrate MuonByteStream to use the new RegSelTools

Changes to remove the use of the old RegSelSvc for the MuonByteStream This should help prevent initialisation issues in the MT code arising from the initialisation of the RegSelSvc

This merge request affects 3 packages:

• MuonSpectrometer/MuonCalib/CscCalib/CscCalibAlgs
• MuonSpectrometer/MuonCnv/MuonByteStream
• Trigger/TriggerCommon/TriggerMenuMT

Adding @rosati ,@wleight ,@nkoehler ,@bernius as watchers

added MuonSpectrometer Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash b13a5017)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21603]

Hi @sutt,

The Trigger_athena_data-test failed, due to an error in SGInputLoader: ERROR Unresolved conditions dependency: ( 'IRegSelLUTCondData' , 'ConditionStore+Tool_Not_Initalised' ) I'm not sure if this is tied to your edits of TriggerMenuMT, or a separate issue in the nightly, could you please advise?

Cheers Nathan (L1)

added review-user-action-required label and removed review-pending-level-1 label

Thanks Nathan, yes, this will be as a result of this merge request - something is configuring one of the Muon RawDataProviders, but the new tool is not being provided, which means that I must have missed somewhere in the configuration where this was needed. I will try to fix this later today, or possibly tomorrow.

Many thanks Mark

added 1 commit

• f41bb7ba - Fix configuration of the RawDataPRoviders in the new configuration

Compare with previous version

This merge request affects 4 packages:

• DetectorDescription/RegionSelector
• MuonSpectrometer/MuonCalib/CscCalib/CscCalibAlgs
• MuonSpectrometer/MuonCnv/MuonByteStream
• Trigger/TriggerCommon/TriggerMenuMT

Adding @sutt ,@rosati ,@wleight ,@nkoehler ,@rbianchi ,@bernius as watchers

added Geometry review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash f41bb7ba)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21759]

Hi @sutt, could you also please run https://gitlab.cern.ch/atlas/athena/blob/master/Simulation/Tests/OverlayTests/test/test_DataOverlay_ConfigTest_Zmumu_Muon.sh to make sure this does not break data overlay.

Thanks!

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 0909cd94 - Fix Muon bystream configuration

Compare with previous version

This merge request affects 5 packages:

• DetectorDescription/RegionSelector
• MuonSpectrometer/MuonCalib/CscCalib/CscCalibAlgs
• MuonSpectrometer/MuonCnv/MuonByteStream
• MuonSpectrometer/MuonConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @sutt ,@rosati ,@wleight ,@nkoehler ,@rbianchi ,@bernius as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result FAILURE (hash 0909cd94)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21792]

Hi,

now all but the MuonConfig_MuonDataDecodeTest succeed:

RegSelCondAlg_RPC    INFO RegSelCondAlg LUT recorded: 'ConditionStore+RegSelLUTCondData_RPC'
ReadCondHandle      ERROR ReadCondHandle: could not find current EventTime [327265,186525031,t:1497896168.189247220,l:100,b:339] for key ConditionStore+MuonMDT_CablingMap
id:  ( 'MuonMDT_CablingMap' , 'ConditionStore+MuonMDT_CablingMap' )   proxy: 0 [0] entries

RegSelCondAlg_TGC   ERROR Failed to retrieve validity range for MuonMDT_CablingMap

Could it be, that the RegSelCondAlgs require a MDT cabling from the conditions store already during initialize, which then cannot be found, since no event context is available yet?

Best, Nico

This makes no sense, the CI tests before, how come they are failing now ? The CondAlgs should not require the cabling during initialise, since they should only be scheduled on demand the first time the lookup tables are requested, and that should only ever be in the event processing.

Mark

Escalating to L2 for further look at the failures. Thanks, Pienpen (L1)