InDetDetDescr+InDetConditions: cmake cleanup

cmake cleanup of InnerDetector/InDetDetDescr and InnerDetector/InDetConditions packages:

• remove atlas_depends_on_subdirs
• update external and link dependencies
• do not install component headers
• enable flake8 where applicable

Jenkins please retry a build

This merge request affects 42 packages. Since this is a long list, I will not print it here.

Adding @goetz ,@cgrefe ,@amorley ,@battagl ,@sroe ,@csuster ,@calfayan ,@sutt ,@stsuno ,@lshan ,@oda as watchers

added InnerDetector Trigger master labels

resolved all threads

CI Result FAILURE (hash 699076e8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 2, warnings 1
AthSimulation: number of compilation errors 0, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22192]

added 61 commits

• 699076e8...f754aacc - 53 commits from branch atlas:master
• 167f75d5 - InDetRegionSelector: cmake cleanup
• 9420e495 - InDetDetDescr: cmake cleanup
• 96b9b2dc - InDetConditions: cmake cleanup
• 74bc5411 - InDetCondFolders: flake8 fixes
• 2d9edc51 - SiLorentzAngleTool: flake8 fixes
• 80ffdc18 - SiPropertiesTool: flake8 fixes
• 1a70838d - SCT_GeoModel: flake8 fix
• 400dba19 - PixelMonitoring: cmake fixes, enable flake8

Compare with previous version

unmarked as a Work In Progress

This merge request affects 43 packages. Since this is a long list, I will not print it here.

Adding @goetz ,@cgrefe ,@amorley ,@ibragimo ,@kzoch ,@battagl ,@sroe ,@csuster ,@calfayan ,@sutt ,@stsuno ,@lshan ,@oda as watchers

added DQ review-pending-level-1 labels

CI Result SUCCESS (hash 400dba19)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22235]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 568e3079

added sweep:ignore label

Hi @fwinkl, could it be that this MR is making DataOverlay test fail in master? It seems some necessary ByteStreamErrs headers are not available. Probably the incremental build did not detect it.

See for example !37582 (merged).

also !37581 (merged) same as !37582 (merged). But not sure if is this one. @tadej will you open a JIRA or so?

OK, will open one under ATEAM soon.

And predictably !37583 (merged) , the next one ...

Opened https://its.cern.ch/jira/browse/ATEAM-663

Thanks! Yes, this is most likely the culprit. Also two units tests in the nightly build showed the problem. Should be fixed with !37587 (merged).