Skip to content

First steps to porting AnalysisTop to R22

Tomas Dado requested to merge tdado/athena:ATmaster into master

Hi all,

First of all, I am sorry for this huge MR. It was agreed with @krumnack and @lheinric that we should simply copy the files from 21.2 and try to make the code compile in R22. This is exactly what I did here.

The plan is to make as few changes as possible in current AnalysisTop code to validate R22. The longer term plan is to move to EventLoop and finally to CPAlgorithms, as agreed with AMG.

Changes

  • Removed TopFakes package as it is obsolete
  • Removed HLUpgrade package as it looked like an easier solution and it wold require significant changes anyway
  • Removed Forward electrons, as this was not properly working anyway and doesnt seem to be supported in R22
  • Changed python scripts to be python3 compliant
  • Had to adjust some includes/CMakeLists
  • Commented out several problematical parts of the code that cannot be compiled and the fix does not seem trivial

Issues

Major

  • Had to comment out everything related to GlobalTriggers - this is needed for may analyses using single lepton triggers but doesnt seem to be available in R22 yet?
  • Had to disable code calibrating jets and MET as it seems the interface for the tools changed?
  • Boosted taggers do not seem to be supported at all, had to deactivate the code

Minor

  • Very recent changes to btag links broke our code in multiple places, commenting out for now
  • Commented out code related to (ghost)tracks as the code could not compile and the solution was not obvious to me
  • FakeBkgTool (IFF tool for fake lepton estimation) does seem to exist in R22, disabled
  • One isolation WP, lowPt, doesnt seem to be available in R22
  • Had to add explicit static_cast<bool> in various places for accept function, is this intended?
  • Commented out lines with TAccept (boosted taggers)

Note, the code only compiles, I have not tested running it on a file produced in R22, but am sure many other changes will be needed.

cc @spalazzo, @omajersk, @bmondal

Cheers, Tomas

Edited by Tomas Dado

Merge request reports

Loading