Preliminary work on optimising for identical Conditions in the jet hypo

The current implementation of the jet hypo FastReducer is inefficient when many identical conditions are present in the tree. This MR starts preliminary work to address the issue.

JIRA ATR-22238

@peter @khoo @bossio @valentem

This merge request affects 11 files:

• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedConditionsDefs.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/ICapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.h

added JetEtmiss Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 99640268)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22710]

changed title from Preliminary work on optimising for identical Conditions in the jet hypo to WIP Preliminary work on optimising for identical Conditions in the jet hypo

removed review-pending-level-1 label

added 1 commit

• f63d87ad - Add check to ensure coapacity of a condition is reached by the satisfying jet groups.

Compare with previous version

changed title from WIP Preliminary work on optimising for identical Conditions in the jet hypo to Preliminary work on optimising for identical Conditions in the jet hypo

This merge request affects 11 files:

• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedConditionsDefs.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/ICapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.h

CI Result SUCCESS (hash f63d87ad)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22789]

added review-pending-level-1 label

Aside from the few small ATLAS style guide comments I made this looks ok to me. The style guide does suggest that inline functions in the header should appear after the class definition , but since these are one line functions I'm not sure we need to do that. Asking L2 shifter (@tadej) to be sure.

added review-pending-level-2 label and removed review-pending-level-1 label

added 154 commits

• f63d87ad...c107b668 - 152 commits from branch atlas:master
• 1e77a205 - Merge tag 'nightly/master/2020-11-02T2101' into master-ATR22238_2
• 4e40f58e - minor syntax changes + dead code removal

Compare with previous version

This merge request affects 13 files:

• Trigger/TrigHypothesis/TrigHLTJetHypo/python/TrigJetHypoToolConfig.py
• Trigger/TrigHypothesis/TrigHLTJetHypo/python/testChainDictMaker.py
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/CapacityCheckedConditionsDefs.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReducer.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/FastReductionMatcher.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/ICapacityCheckedCondition.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/groupsMatcherFactoryMT.h

added review-pending-level-1 label and removed review-pending-level-2 label

CI Result SUCCESS (hash 4e40f58e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22863]