Adding ChargeIDSelectorTool in Release 22 (ECIDS)

Adding the ElectronChargeIDSelectorTool (ECIDS) which existed in R21.

This package runs BDT to classify Electrons with correctly reconstructed charge against so-called charge-flip electrons. It runs in the derivation production step, hence electrons in DAOD gets decorated with the BDT output.

Changes in two packages:

• ElectronPhotonSelectorTools (now depends on MVAUtils)
• EgammaDerivation

added Analysis Derivation Egamma labels

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

Affected files list will not be printed in this case

added master review-pending-level-1 labels

changed the description

changed the description

CI Result FAILURE (hash d4b2fd67)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 62
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23788]

Hello, there is one compilation error in ElectronPhotonSelectorTools, could you have a look into it? Thanks, Pienpen (L1)

added review-user-action-required label and removed review-pending-level-1 label

Thanks for your comment, could you tell me how I can reproduce this error? Which setup should I use? I did the following but I got completely different error...

` setupATLAS

lsetup git

git atlas init-workdir https://:mociduki@gitlab.cern.ch:8443/mociduki/athena.git

cd athena

git atlas addpkg ElectronPhotonSelectorTools

git checkout -b 22.0-ECIDS upstream/master

mkdir ../build; cd ../build

asetup AnalysisBase,master,latest

cmake ../athena/Projects/WorkDir

cmake --build ./ `

Please never mind, I just manage to reproduce the error. I will fix it and apply them.

added 1 commit

• d2eff129 - Update AsgElectronChargeIDSelectorTool.cxx, in order to avoid compilation error in AnalysisBase

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash d2eff129)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23913]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 8c03f95e - Update CMakeLists.txt

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

Affected files list will not be printed in this case

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 8c03f95e)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23976]

resolved all threads

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 78ec3da1

added sweep:ignore label

mentioned in merge request !39043 (closed)