Skip to content
Snippets Groups Projects

Save only first status word in ROBDataStruct

Merged Aleksandra Poreba requested to merge aporeba/athena:rob-single-status into master
All threads resolved!

Change ROBDataStruct to hold the only first status word

Follow up to !38376 (merged)

Tagging @rbielski @tamartin

Merge request reports

Pipeline #2111735 passed

Pipeline passed for 5753b7be on aporeba:rob-single-status

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Nov 24, 2020 2:49pm UTC)

Merge details

  • Changes merged into master with 9c57d314 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 607ffab0 - Change EDM rob_status_word name and type

    Compare with previous version

  • This merge request affects 4 packages:

    • HLT/Trigger/TrigControl/TrigServices
    • Trigger/TrigDataAccess/TrigDataAccessMonitoring
    • Trigger/TrigMonitoring/TrigCostMonitorMT
    • Trigger/TriggerCommon/TrigEDMConfig

    Affected files list will not be printed in this case

    Adding @sutt ,@okuprash ,@fwinkl ,@wiedenma ,@rbielski ,@bernius as watchers

  • added 1 commit

    • 5753b7be - Change EDM rob_status_word name and type

    Compare with previous version

  • This merge request affects 4 packages:

    • HLT/Trigger/TrigControl/TrigServices
    • Trigger/TrigDataAccess/TrigDataAccessMonitoring
    • Trigger/TrigMonitoring/TrigCostMonitorMT
    • Trigger/TriggerCommon/TrigEDMConfig

    Affected files list will not be printed in this case

    Adding @sutt ,@okuprash ,@fwinkl ,@wiedenma ,@rbielski ,@bernius as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 607ffab0)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23821]

  • :white_check_mark: CI Result SUCCESS (hash 5753b7be)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23824]

  • Tim Martin resolved all threads

    resolved all threads

  • code was reviewed, seems fine except for one issue pointed out above.

    Roman(L1)

  • @rlysak, which issue? All threads were resolved 4h ago and the latest pipeline was all green.

  • @rbielski : sorry, I think I pushed a wrong button ('start review' instead of 'add comment')

  • Roman Lysak resolved all threads

    resolved all threads

  • all issues resolved, code seems fine, CI passed, approving

    Roman(L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 9c57d314

  • Please register or sign in to reply
    Loading