Skip to content
Snippets Groups Projects

AthenaPoolTest: test definition cleanup

Merged AthenaPoolTest: test definition cleanup
fwinkl/athena:test_athenapooltest into master
Merged Frank Winklmeier requested to merge fwinkl/athena:test_athenapooltest into master

Major cleanup of the unit test definition:

  • Use official post.sh script for reference comparison
  • Fix test dependencies. Previously all tests were run sequentially. In principle there could be a problem when multiple jobs try to write to the same PoolCatalog. If that happens we may need to define separate run directories for each test.
  • Copy all references to git to avoid the awkward EOS copy. Some of the references are a few 100kB, however, they compress to almost nothing so this should not be an issue for git storage.
  • Delete all obsolete test scripts.
  • Fix a few mistakes in job options that the previous post-processing script missed.

Merge request reports

Pipeline #2117725 passed

Stage: external

Pipeline passed for 79b3dcf1 on fwinkl:test_athenapooltest

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Nov 24, 2020 3:55pm UTC)

Merge details

  • Changes merged into master with b6051da7.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 176K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataWriter.ref

    :pencil: 336K in file AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataRead.ref

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • AtlasTest/DatabaseTest/AthenaPoolTest

    This merge request affects 28 files:

    • AtlasTest/DatabaseTest/AthenaPoolTest/CMakeLists.txt
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2Write.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/AthenaPoolTestStep2WriteDoubleSelector.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/DoubleEventSelectorOverlayTest.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/DoubleEventSelectorOverlayTest.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoRead.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoRead.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWrite.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWrite.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep2.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep2.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep3.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep3.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep4.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep4.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep5.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/EventInfoWriteStep5.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataRead.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/InDetRawDataWriter.ref
    • AtlasTest/DatabaseTest/AthenaPoolTest/share/ReadRDODoubleSelector.py
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/athenapooltest_test.sh.in
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/atlfast_write_pre_check.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/diff_check.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/dumpAttr.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/lfn_test_pre_check.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/post_check.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/post_check_with_select.sh
    • AtlasTest/DatabaseTest/AthenaPoolTest/test/pre_check.sh

    Adding @jchapman ,@tkharlam ,@ahaas ,@tadej as watchers

  • ATLAS Robot added Overlay Test master review-pending-level-1 labels

    added Overlay Test master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 79b3dcf1)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23905]

  • R
    Roman Lysak @rlysak ·
    Developer

    code changes look fine, approving.

    Roman(L1)

  • Roman Lysak added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit b6051da7

    mentioned in commit b6051da7

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

Please register or sign in to reply