Another Muon memory leak fix

The call-chain from MuonCombinedInDetExtensionAlg::execute -> MuonInsideOutRecoTool::cleanup() did work b/c IMuonCombinedInDetExtensionTool::cleanUp() wasn't declared virtual. This MR fixes this shortcoming.

This merge request affects 3 packages:

• Reconstruction/MuonIdentification/MuonCombinedAlgs
• Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
• Reconstruction/MuonIdentification/MuonCombinedTrackFindingTools

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash 74c6cf7a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23911]

Code changes look fine, approving. Pienpen (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 8b3b4179

Hi @wlampl,

FYI: I just compiled MuonCombinedAlgs, MuonCombinedToolInterfaces, MuonCombinedTrackFindingTools (the packages changed in this MR) on top of 2020-11-23T2101, thus, a very similar environment as the changes of this MR, and when I run Reco_tf.py --AMI=q431 --athenaopts="--threads=1", I get a seg fault

Event counter: 1
Slot   0 : Current algorithm = MuonCaloTagAlg 
         : Last Incident = BeginIncFiringAlg:BeginEvent
         : Event ID      = [330470,1183722158,t:1500867637.679166225,l:310,b:21]

Unfortunately no stack trace. We will see if something is wrong in my setup (since I only compiled these 3 packages on top of master) or if tomorrow, also the --threads 1 ART test will show this crash.

Best, Nico

Hi @nkoehler,

I saw that error, the solution was to recompile also one more package (Reconstruction/MuonIdentification/MuonCombinedBaseTools)

• Walter

added sweep:ignore label