Partial Event Building: Update configuration and add unit tests

Changes introducing extensive unit testing of partial event building configuration in TriggerMenuMT (ATR-22242).

1. Replace derived config classes in TrigPartialEventBuildingConfig with config functions returning a tool instance (required for the unit test from point 3 below to work correctly).
2. Extend menu_config_tests.py with a new consistency check of partial event building configuration.
3. Add a unit test for the EventBuildingSequenceSetup module testing the configuration of PEB writer tools.
4. Fix stream misconfiguration uncovered by the test added in point 2. The "CSCPEB" chain was streamed to a full-event-building stream "CSC". That stream should not be full-event-building.

Trigger/TrigAlgorithms/TrigPartialEventBuilding/python/TrigPartialEventBuildingConfig.py

@@ -2,13 +2,13 @@
 #  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 #
 
-from TrigPartialEventBuilding.TrigPartialEventBuildingConf import StaticPEBInfoWriterTool, RoIPEBInfoWriterTool
+from AthenaConfiguration.ComponentFactory import CompFactory
 from TrigEDMConfig.DataScoutingInfo import getFullHLTResultID
 from libpyeformat_helper import SourceIdentifier, SubDetector
 from RegionSelector import RegSelToolConfig
 
 
-class StaticPEBInfoWriterToolCfg(StaticPEBInfoWriterTool):
+def StaticPEBInfoWriterToolCfg(name='StaticPEBInfoWriterTool'):
     def addROBs(self, robs):
         self.ROBList.extend(robs)
 
@@ -23,8 +23,17 @@ class StaticPEBInfoWriterToolCfg(StaticPEBInfoWriterTool):
         ctpResultSID = SourceIdentifier(SubDetector.TDAQ_CTP, moduleId)
         self.addROBs([ctpResultSID.code()])
 
+    CompFactory.StaticPEBInfoWriterTool.addROBs = addROBs
+    CompFactory.StaticPEBInfoWriterTool.addSubDets = addSubDets
+    CompFactory.StaticPEBInfoWriterTool.addHLTResultToROBList = addHLTResultToROBList
+    CompFactory.StaticPEBInfoWriterTool.addCTPResultToROBList = addCTPResultToROBList
 
-class RoIPEBInfoWriterToolCfg(RoIPEBInfoWriterTool):
+    tool = CompFactory.StaticPEBInfoWriterTool(name)
+
+    return tool
+
+
+def RoIPEBInfoWriterToolCfg(name='RoIPEBInfoWriterTool'):
     def addRegSelDets(self, detNames):
         '''
         Add RegionSelector tools for given detector look-up tables to build PEB list of ROBs
@@ -51,7 +60,7 @@ class RoIPEBInfoWriterToolCfg(RoIPEBInfoWriterTool):
 
     def addSubDets(self, dets):
         '''Add extra fixed list of SubDets independent of RoI'''
-        self.ExtraSubDets.extend(dets)
+        self.ExtraSubDets.extend([int(detid) for detid in dets])
 
     def addHLTResultToROBList(self, moduleId=getFullHLTResultID()):
         hltResultSID = SourceIdentifier(SubDetector.TDAQ_HLT, moduleId)
@@ -60,3 +69,13 @@ class RoIPEBInfoWriterToolCfg(RoIPEBInfoWriterTool):
     def addCTPResultToROBList(self, moduleId=0):
         ctpResultSID = SourceIdentifier(SubDetector.TDAQ_CTP, moduleId)
         self.addROBs([ctpResultSID.code()])
+
+    CompFactory.RoIPEBInfoWriterTool.addRegSelDets = addRegSelDets
+    CompFactory.RoIPEBInfoWriterTool.addROBs = addROBs
+    CompFactory.RoIPEBInfoWriterTool.addSubDets = addSubDets
+    CompFactory.RoIPEBInfoWriterTool.addHLTResultToROBList = addHLTResultToROBList
+    CompFactory.RoIPEBInfoWriterTool.addCTPResultToROBList = addCTPResultToROBList
+
+    tool = CompFactory.RoIPEBInfoWriterTool(name)
+
+    return tool