Disable Trigger in RecExCommon unless really needed

The whole "flags saga" triggered by !38449 (merged) (see Issue Links in ATR-22360) uncovered that some jobs were trying to run Trigger selection algorithms when they clearly shouldn't have. Not only they were trying to run something they don't need, but also something that is deprecated (legacy trigger) and on top of that was misconfigured in these jobs.

The two cases reported in ATR-22516 and ATR-22515 were jobs starting from RDO without any Trigger content and intending to run RAWtoESD without Trigger. Instead of what was intended, these jobs were actually configuring Trigger like if they were legacy RDOtoRDOTrigger jobs rather than RAWtoESD. Another similar case was reported in ATLASRECTS-5833.

Fix this in the following way:

1. Set recAlgs.doTrigger to False by default. Add a "TODO" comment saying it should be removed once we retire legacy Trigger in r22.
2. Disable rec.doTrigger if running on POOL file without any Trigger content (like RDO) while also recAlgs.doTrigger=False. This fixes the two tickets mentioned above.
3. Move the ESDtoAOD Run-3 Trigger setup in RecExCommon_topOptions.py under if rec.doTrigger: and remove Run-3 Trigger special case from ESDtoAOD transform skeleton. (ATR-19982)
4. Fix the fallout: clean up a bunch of cases in Trigger configuration which had either explicit or implicit assumption of recAlgs.doTrigger.

Multiple local tests succeeded, but running full-unit-tests on this one as the RecExCommon configuration is clearly very fragile and the number of workflows affected by !38449 (merged) was slightly beyond my expectations.

added full-unit-tests label

This merge request affects 3 packages:

• Reconstruction/RecExample/RecExCommon
• Reconstruction/RecExample/RecExConfig
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz as watcher

added Reconstruction Trigger master review-pending-level-1 labels

Forgot to add full-unit-tests before clicking "Submit"

I'll check later if it got picked up correctly and will restart CI if not.

changed the description

added review-user-action-required label and removed review-pending-level-1 label

CI Result FAILURE (hash e2bc0459)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25068]

Hi @rbielski,

thanks for this MR. Just for me to understand the timescale on this: Should we go ahead updating the Run3 reco CI including doTrigger=False such that we can update the CI already now (without waiting for this MR) or should we wait with the CI update for this MR going in such that we can run with autoConfiguration only? I think it basically depends on when/if you have time to look into this MR...

Thanks, Nico

marked as a Work In Progress

changed the description

changed the description

added 324 commits

• e2bc0459...eb12b181 - 322 commits from branch atlas:master
• 27e5535b - Disable Trigger in RecExCommon unless really needed
• 7aef499d - Clean up Trigger configuration from incorrect assumptions of recAlgs.doTrigger

Compare with previous version

resolved all threads

Jenkins please retry a build

This merge request affects 5 packages:

• Reconstruction/RecExample/RecExCommon
• Reconstruction/RecExample/RecExConfig
• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigMonitoring/TrigCaloMonitoring
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz ,@joheinri ,@damazio as watchers

added DQ label and removed review-user-action-required label

CI Result FAILURE (hash 7aef499d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25187]

added 51 commits

• 7aef499d...198c1e90 - 49 commits from branch atlas:master
• 12dac682 - Disable Trigger in RecExCommon unless really needed
• 3694d649 - Clean up Trigger configuration from incorrect assumptions of recAlgs.doTrigger

Compare with previous version