AthenaCommon: Bugfix athena preload logic
This was a bit tricky. The runwrapper script that's produced by the standard job transforms looks like:
athena.py --preloadlib=[...]/libintlc.so.5:[...]/libimf.so --drop-and-reload runargs.RAWtoALL.py RecJobTransforms/skeleton.RAWtoALL_tf.py
When this is executed, we call athena
twice. The first time --drop-and-reload
is passed on as an argument but the second time it's not (indeed we seem to pass --minimal
instead). If ATHENA_DROP_RELOAD
is exported, not set, then we never end up preloading either libintlc
or libimf
because ATHENA_DROP_RELOAD
is always globally defined and set to 1. This MR fixes that.
It turns out that we've never been using IMF
as part of our standard jobs in master
. So, this'll most probably fail the digest tests where we don't do anything special. Before merging this in, I'll first update the CI tests to explicitly disable IMF
, then we can proceed w/ merging this.
Needless to say, this'll give us a bit of performance boost all across the board in standard jobs.
Let me tag @fwinkl and @ssnyder. I'd really appreciate a second look on this.
Closes ATEAM-689