Skip to content
Snippets Groups Projects

Bugfix for the Event Service

Merged Bugfix for the Event Service
tsulaia/athena:master-mpes into master
All threads resolved!
Merged Vakhtang Tsulaia requested to merge tsulaia/athena:master-mpes into master
All threads resolved!

Bugfix in the mechanism of handling failed MP workers in the Event Service. This patch covers the case when a worker fails to transition from the event processing state into the finalization state after receiving "No more events" message from the range scatterer. The idea here is that instead of releasing a fixed number of workers (nprocs), the scatterer will keep releasing the workers until it gets a signal that all of them have finished.

Merge request reports

Checking pipeline status.

Merged by Johannes ElmsheuserJohannes Elmsheuser 4 years ago (Dec 25, 2020 2:03pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Abhishek Nag added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Vakhtang Tsulaia added 1 commit

    added 1 commit

    • f2a79b01 - Bugfix for the Event Service

    Compare with previous version

  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • Vakhtang Tsulaia removed review-user-action-required label

    removed review-user-action-required label

  • Vakhtang Tsulaia added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Control/AthenaMPTools

    This merge request affects 4 files:

    • Control/AthenaMPTools/src/EvtRangeProcessor.cxx
    • Control/AthenaMPTools/src/EvtRangeProcessor.h
    • Control/AthenaMPTools/src/EvtRangeScatterer.cxx
    • Control/AthenaMPTools/src/EvtRangeScatterer.h

    Adding @ssnyder as watcher

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Author Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f2a79b01)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 2
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25681]

  • Abhishek Nag
    Abhishek Nag @abnag ·

    MR looks good. Approving (L1)

  • Abhishek Nag added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser merged

    merged

  • Johannes Elmsheuser mentioned in commit 31216d3a

    mentioned in commit 31216d3a

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply