A bit of cleanup in the InnerTracker, PhysicsAnalysis and Tracking

In this MR:

• remove some stray or wrongly-placed (e.g. "const methods" before non-const methods) comments

This merge request affects 4 packages:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetValidation/InDetRecStatistics
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• Tracking/TrkValidation/TrkValAlgs

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

added Analysis InnerDetector Tracking master review-pending-level-1 labels

added 1 commit

• d13a7baf - More cleanup

Compare with previous version

This merge request affects 7 packages:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetValidation/InDetRecStatistics
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• PhysicsAnalysis/TruthParticleID/McParticleTools
• PhysicsAnalysis/TruthParticleID/McParticleUtils
• Tracking/TrkTruthTracks/TrkTruthTrackTools
• Tracking/TrkValidation/TrkValAlgs

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

changed the description

added 1 commit

• fa70e23b - Continue the cleanup

Compare with previous version

This merge request affects 7 packages:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetValidation/InDetRecStatistics
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• PhysicsAnalysis/TruthParticleID/McParticleTools
• PhysicsAnalysis/TruthParticleID/McParticleUtils
• Tracking/TrkTruthTracks/TrkTruthTrackTools
• Tracking/TrkValidation/TrkValAlgs

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

CI Result SUCCESS (hash 5ebe274d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25716]

CI Result SUCCESS (hash fa70e23b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25720]

CI Result SUCCESS (hash d13a7baf)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25718]

Jenkins please retry a build

This merge request affects 7 packages:

• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetValidation/InDetRecStatistics
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• PhysicsAnalysis/TruthParticleID/McParticleTools
• PhysicsAnalysis/TruthParticleID/McParticleUtils
• Tracking/TrkTruthTracks/TrkTruthTrackTools
• Tracking/TrkValidation/TrkValAlgs

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

CI Result SUCCESS (hash fa70e23b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25732]

Code changes look fine, could you please edit the title a bit to tell where these changes have been made. Once it is done, I am happy to approve the MR. Thanks, Pienpen(L1)

added review-user-action-required label and removed review-pending-level-1 label

changed title from A bit of cleanup to A bit of cleanup in the InnerTracker, PhysicsAnalzsis and Tracking

Hi @pseema ,

done.

BEst regards,

Andrii

changed title from A bit of cleanup in the InnerTracker, PhysicsAnalzsis and Tracking to A bit of cleanup in the InnerTracker, PhysicsAnalysis and Tracking

added review-pending-level-1 label and removed review-user-action-required label

This MR looks good to me. Approving now.

Serhat (L1)