Python3 + flake8 ElectronPhotonFourMomentumCorrection

Several scripts used to test ElectronPhotonFourMomentumCorrection tool have been properly ported to python3 and flake8 warnings have been fixed. Now the scripts use the latest matplotlib api presently provided by cvmfs.

Closes ATLASG-1579

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection

This merge request affects 3 files:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/merge_scale_histograms.py
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/plot.py
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/run_xAOD_ElectronPhotonFourMomentumCorrection.py

added Analysis Egamma master review-pending-level-1 labels

You forgot to enable flake8 for this package:

atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} ) 

Otherwise the CI won't tell us if the warnings are really fixed.

added 1 commit

• ef8cfa21 - enable flake8 in CMakeLists.txt

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection

This merge request affects 4 files:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/CMakeLists.txt
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/merge_scale_histograms.py
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/plot.py
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/python/run_xAOD_ElectronPhotonFourMomentumCorrection.py

CI Result SUCCESS (hash ef8cfa21)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25772]

CI Result SUCCESS (hash 47838f0a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25770]

Changes look fine. Approving.

Serhat (L1)

added review-approved label and removed review-pending-level-1 label

resolved all threads

merged

mentioned in commit 1271275f

added sweep:ignore label