Skip to content
Snippets Groups Projects

JetMonitoring: enable flake8, remove Py2 code

Merged JetMonitoring: enable flake8, remove Py2 code
fwinkl/athena:flake8_jetmon into master
All threads resolved!
Merged Frank Winklmeier requested to merge fwinkl/athena:flake8_jetmon into master
All threads resolved!

Enable flake8 checking and remove the Py2 backwards-compatibility code. Also fix an obvious logic bug in HIJetMonitoringHistos.py.

Edited by Frank Winklmeier

Merge request reports

Pipeline #2216042 passed

Stage: external

Pipeline passed for 649a36e7 on fwinkl:flake8_jetmon

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 4 years ago (Jan 8, 2021 7:01am UTC)

Merge details

  • Changes merged into master with 7bb6c91e (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier resolved all threads

    resolved all threads

  • Frank Winklmeier added 1 commit

    added 1 commit

    • 649a36e7 - JetMonitoring: Fix logic bug in HIJetMonitoringHistos.py

    Compare with previous version

  • Frank Winklmeier changed the description

    changed the description

  • Frank Winklmeier removed review-approved label

    removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Reconstruction/Jet/JetMonitoring

    This merge request affects 10 files:

    • Reconstruction/Jet/JetMonitoring/CMakeLists.txt
    • Reconstruction/Jet/JetMonitoring/python/HIJetHistoTools.py
    • Reconstruction/Jet/JetMonitoring/python/HIJetMonitoringHistos.py
    • Reconstruction/Jet/JetMonitoring/python/JetAttributeHistoManager.py
    • Reconstruction/Jet/JetMonitoring/python/JetHistoManager.py
    • Reconstruction/Jet/JetMonitoring/python/JetHistoTools.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringConfig.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringHistos.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py
    • Reconstruction/Jet/JetMonitoring/python/JetStandardHistoSpecs.py

    Adding @goetz as watcher

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 649a36e7)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25935]

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Developer

    Jenkins please retry a build

  • Vakhtang Tsulaia enabled an automatic merge when the pipeline for 649a36e7 succeeds

    enabled an automatic merge when the pipeline for 649a36e7 succeeds

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Reconstruction/Jet/JetMonitoring

    This merge request affects 10 files:

    • Reconstruction/Jet/JetMonitoring/CMakeLists.txt
    • Reconstruction/Jet/JetMonitoring/python/HIJetHistoTools.py
    • Reconstruction/Jet/JetMonitoring/python/HIJetMonitoringHistos.py
    • Reconstruction/Jet/JetMonitoring/python/JetAttributeHistoManager.py
    • Reconstruction/Jet/JetMonitoring/python/JetHistoManager.py
    • Reconstruction/Jet/JetMonitoring/python/JetHistoTools.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringConfig.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringHistos.py
    • Reconstruction/Jet/JetMonitoring/python/JetMonitoringStandard.py
    • Reconstruction/Jet/JetMonitoring/python/JetStandardHistoSpecs.py

    Adding @goetz as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 649a36e7)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25960]

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 7bb6c91e

    mentioned in commit 7bb6c91e

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply