Tau Track Vertex Association Tool update

Use the new track vertex association tool in TauVertexFinder.

Previously it used the TVA tool from jet reconstruction: https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/Jet/JetRecTools/Root/TrackVertexAssociationTool.cxx

This was ran at the start of tauRec in a separate algorithm to produce the tva object. With the new tool this is no longer necessary: https://gitlab.cern.ch/atlas/athena/-/blob/master/InnerDetector/InDetRecTools/TrackVertexAssociationTool/Root/TrackVertexAssociationTool.cxx

For now I have used custom settings for the new tool that match the parameters used previously. In q431 it appears to give the same output as before. I also ran studies on the vertex finding efficiency, and confirmed the two tools give the same tau vertices.

This merge request affects 3 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools
• Trigger/TrigAlgorithms/TrigTauRec

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@ademaria ,@adbailey ,@malconad ,@carquin ,@xiaozhon as watchers

added Reconstruction Tau Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 9edd6aa1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25932]

The failure in Trigger_athena_MC look unrelated to the changes. There are some warnings related to TauRecConfigured.py and TauVertexFinder.cxx. Could you please have a look into that? Thanks, Pienpen (L1)

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/tauRec/python/TauRecConfigured.py:17:1: warning: F401 'AthenaCommon.BeamFlags.jobproperties' imported but unused

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/tauRecTools/src/TauVertexFinder.cxx:264:106: warning: unused parameter 'sumTrackAll' [-Wunused-parameter]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• bb4e99e0 - Fix unused variable warnings

Compare with previous version

Hi, thanks for pointing those out, it should be fixed now.

This merge request affects 3 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools
• Trigger/TrigAlgorithms/TrigTauRec

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@ademaria ,@adbailey ,@malconad ,@carquin ,@xiaozhon as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash bb4e99e0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25996]

added 1 commit

• 834bdf42 - Fix unused python import warning

Compare with previous version

it found another warning, it was an unused variable in the python config again. It should be fixed already.

This merge request affects 3 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools
• Trigger/TrigAlgorithms/TrigTauRec

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@ademaria ,@adbailey ,@malconad ,@carquin ,@xiaozhon as watchers

CI Result SUCCESS (hash 834bdf42)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26007]

I just went through the changes, and they look fine to me, apart from the one line I pointed out.

Serhat (L1)

added 1 commit

• 5357d891 - Update comments for TauVertexFinder

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/tauRec
• Reconstruction/tauRecTools
• Trigger/TrigAlgorithms/TrigTauRec

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@ademaria ,@adbailey ,@malconad ,@carquin ,@xiaozhon as watchers

CI Result SUCCESS (hash 5357d891)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26073]

added review-approved label and removed review-pending-level-1 label

resolved all threads

merged

mentioned in commit 24228ea1

added sweep:ignore label