Migrate RecTransformTests reconstruction tests to threaded setups
Until now all these reconstruction tests ran in serial mode. Now they run with one thread and also run an additional test in parallel (same config) with five threads. The tests specific to physics validation still run in serial mode - my understanding is we won't run physics validation NTUP_PHYSVAL production in MT mode (is that correct @jferrand ,@miochoa ?)
Merge request reports
Activity
This merge request affects 1 package:
- Reconstruction/RecExample/RecJobTransformTests
This merge request affects 43 files. Since this is a long list, it will not be printed.
Adding @goetz as watcher
added Reconstruction Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash 042de5a6)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25987]removed review-pending-level-1 label
added review-user-action-required label
"Code changes look, at first blush fine, but there is a lot of what looks like cut/pasting (nature of the beast)?"
Yes, its a cut-paste job. Eventually we would only have one set (once running with > 1 thread becomes default and stable in some months).
"Needs a comment from @jferrand, @miochoa (see description)"
If needed I can open another MR if they are not available to comment. The comment only affects whether to do the same thing for 2-3 tests I did not migrate and does not affect the changes I have already made.
Cheers,
Mark
removed review-user-action-required label
added review-pending-level-1 label
added review-approved label and removed review-pending-level-1 label
mentioned in commit fe8157b4
added sweep:ignore label