WIP Jet Hypo: add Phi Condition - possible use: define a hole in the detector.

The new Phi Condition together with an eta Condition and Condition Inverter will make it possible to mask off Eta-Phi regions of the detector when running the jet hypo.

@jbossio @valentem @khoo @peter

added 1 deleted label

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigHLTJetHypo

This merge request affects 7 files:

• Trigger/TrigHypothesis/TrigHLTJetHypo/python/TrigJetHypoToolConfig.py
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/PhiConditionMT.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/PhiConditionMT.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigHLTJetHypoUtils/HypoJetDefs.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetConditionConfig_phi.cxx
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetConditionConfig_phi.h
• Trigger/TrigHypothesis/TrigHLTJetHypo/src/components/TrigHLTJetHypo_entries.cxx

added JetEtmiss Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 5b891c83)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26225]

This seems to be causing the test failure. Tom - L1 shifter

changed this line in version 2 of the diff

added review-user-action-required label and removed review-pending-level-1 label

Indeed. Thanks for looking into this, Tom. I am in the process of providing configuration for test chain that uses the recently added functionaliry. The flag will be reset in the next git push.

added 3 commits

• 4c2387b2 - Jet hypo: mosty make configuration of FastReductionCondition filtering more systematic.
• f3e7823e - jet hypo: removes unused code.
• 47488c45 - Turn off jet hypo debug flag prior to git push

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@hrussell ,@ademaria ,@malconad ,@carquin ,@dzanzi ,@bernius as watchers

added TriggerMenu review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 47488c45)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26415]

added 2 commits

• c2f33e6b - jet hypo - more work in handling Condition Filters
• e87d4e99 - jet hypo: debug flag set to False

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad ,@jpanduro as watchers

added changes-trigger-counts label

CI Result FAILURE (hash e87d4e99)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26421]

Hi @rbielski

The above report claims there are chain count differences for HLT_j80_0eta240_2j60_320eta490_j0_dijetSEP80j1etSEP0j1eta240SEP80j2etSEP0j2eta240SEP700djmass_L1J20

However, I do not see these differences locally. Details follow.

Do you have any idea why there is this difference?

thanks,

Peter

I have just run the ART tests on the code in master.

The error report is a little confusing, as it seems to refer to two chains:

HLT_j60_j0_fbdjshared_L1J20 HLT_j80_0eta240_2j60_320eta490_j0_dijetSEP80j1etSEP0j1eta240SEP80j2etSEP0j2eta240SEP700djmass_L1J20

I believe the first is the relevant chain.

The complaint appears to be that there are now 176 step features, while there were 179. I see, both in the local master tests and the ART tests on the submitted code, through jet hypo dumps, that there are 179 reported jets in both cases.

runTrigART -m gives

NFO ---------------------------------------------------------------------------------------------------------------------------------------------- INFO | test_trigAna_RDOtoRDOTrig_v1Dev_build.py | Reco_tf: 0, CheckLog: 0, MessageCount: 3, RootComp: 26, CountRefComp: 0, ZeroCounts: 0, exit: 0 | INFO | test_trigP1_v1Dev_build.py | athenaHLT: 0, CheckLog: 0, MessageCount: 2, RootComp: 173, ZeroCounts: 0, exit: 0 | INFO | test_trig_data_newJO_build.py | athena: 0, ExecSummary: 0, CheckLog: 0, exit: 0 | INFO | test_trig_data_v1Dev_build.py | athena: 0, CheckLog: 0, MessageCount: 0, RootComp: 11, CountRefComp: 0, ZeroCounts: 0, exit: 0 | INFO ---------------------------------------------------------------------------------------------------------------------------------------------- INFO ================================================== INFO All 4 executed tests succeeded INFO =====================================

And the code has been pushed:

-bash-4.2$ pwd /afs/cern.ch/work/p/peter/public/Dev2/ART0/runTrigART/results/runTrigART/test_trigAna_RDOtoRDOTrig_v1Dev_build -bash-4.2$ echo $WDEV /afs/cern.ch/work/p/peter/public/Dev2 -bash-4.2$ diff ref_RDOtoRDOTrig_v1Dev_build.new $WDEV/athena/Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref -bash-4.2$ cd $WDEV/athena/Trigger/TrigValidation/TrigAnalysisTest/share
-bash-4.2$ git status On branch master-22604-0 Your branch is up to date with 'origin/master-22604-0'.

Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: ../../../TrigHypothesis/TrigHLTJetHypo/python/TrigJetHypoToolConfig.py modified: ../../../TrigHypothesis/TrigHLTJetHypo/python/testChainDictMaker.py

no changes added to commit (use "git add" and/or "git commit -a") -bash-4.2$ git push Everything up-to-date

Unfortunately I don't have any good idea why the feature count for HLT_j80_0eta240_2j60_320eta490_j0_dijetSEP80j1etSEP0j1eta240SEP80j2etSEP0j2eta240SEP700djmass_L1J20 changes in this MR while it cannot be reproduced locally. I would normally suggest to rebase the branch on top of upstream/master and use the latest nightly to recompile and test again locally, but we are currently having a serious problem with nightlies and the last three are broken. I'm afraid you will need to wait until we have working nightlies again. I hope tonight's release will be fine, but I think investigation/fixing is still in progress.

ok, thanks for the update

Moving back to user until test pass. (L1)

removed review-pending-level-1 label