Skip to content
Snippets Groups Projects

add AnaReentrantAlgorithm

Merged Nils Erik Krumnack requested to merge krumnack/athena:reentrant_alg into master
All threads resolved!

Mostly a copy-and-paste of AnaAlgorithm, with cleanup and updates to inherit from AthReentrantAlgorithm.

Probably the main thing to look for for the reviewer are copy-and-paste errors.

Not sure if it was @tadej, @jburr, or @khoo who kept asking for this, but here it is. Please note that the systematics handles will need updates to work with reentrant algorithms (to say nothing of the ISystematicsTool).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nils Erik Krumnack added 108 commits

    added 108 commits

    Compare with previous version

  • This merge request affects 3 packages:

    • PhysicsAnalysis/D3PDTools/AnaAlgorithm
    • PhysicsAnalysis/D3PDTools/EventLoop
    • PhysicsAnalysis/D3PDTools/EventLoopTest

    Affected files list will not be printed in this case

    Adding @krumnack as watcher

  • Nils Erik Krumnack resolved all threads

    resolved all threads

  • :negative_squared_cross_mark: CI Result FAILURE (hash d965898b)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26940]

  • Since this only adds new code and doesn't change any code, the failure in the trigger test shouldn't be caused by this MR.

  • Unrelated CI failure. Approving.

    Cheers, Volker (L1)

  • mentioned in commit 65ce9681

  • Nils Erik Krumnack mentioned in merge request !42111 (merged)

    mentioned in merge request !42111 (merged)

  • Please register or sign in to reply
    Loading