Try to Clean-up Surfaces:: transform(), center(), normal()

added 61 commits

• e23d0e35...4afccec0 - 60 commits from branch atlas:master
• 5829c9f8 - merge upstream, resolve conflicts

Compare with previous version

This merge request affects 1 package:

• Tracking/TrkDetDescr/TrkSurfaces

This merge request affects 11 files:

• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/ConeSurface.h
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/ConeSurface.icc
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/CylinderSurface.h
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/CylinderSurface.icc
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PerigeeSurface.h
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PerigeeSurface.icc
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/PlaneSurface.h
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/Surface.h
• Tracking/TrkDetDescr/TrkSurfaces/TrkSurfaces/Surface.icc
• Tracking/TrkDetDescr/TrkSurfaces/src/ConeSurface.cxx
• Tracking/TrkDetDescr/TrkSurfaces/src/CylinderSurface.cxx

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 5829c9f8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 83
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26860]

marked this merge request as draft

removed review-pending-level-1 label

added 1 commit

• d3bb0bfd - use normal/center from Trk::Surface

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• Tracking/TrkDetDescr/TrkGeometrySurfaces
• Tracking/TrkDetDescr/TrkSurfaces

Affected files list will not be printed in this case

Adding @amorley as watcher

CI Result FAILURE (hash d3bb0bfd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26919]

marked this merge request as ready

Jenkins please retry a build

This merge request affects 2 packages:

• Tracking/TrkDetDescr/TrkGeometrySurfaces
• Tracking/TrkDetDescr/TrkSurfaces

Affected files list will not be printed in this case

Adding @amorley as watcher

added review-pending-level-1 label

CI Result SUCCESS (hash d3bb0bfd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26971]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 03cdfd48

added sweep:ignore label

This causes ATLASRECTS-5963.