Fix placement for SG objects w/o keys (as seen for q431 EventInfo).

added full-unit-tests label

Tag @mnowak , @amete

This merge request affects 1 package:

• Database/AthenaPOOL/AthenaPoolCnvSvc

This merge request affects 1 file:

• Database/AthenaPOOL/AthenaPoolCnvSvc/src/AthenaPoolConverter.cxx

Adding @ssnyder ,@mnowak as watchers

added Database master review-pending-level-1 labels

CI Result FAILURE (hash e13874cc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26933]

The TrkEventAthenaPool_TrkEventTPCnv test failures are a known (and fixed) issue. But these look related:

The following tests FAILED:
	 45 - IOVDbTestAlg_IOVDbTestReadCool_ctest (Failed)
	 47 - IOVDbTestAlg_IOVDbTestReadCool2_ctest (Failed)
	 49 - IOVDbTestAlg_IOVDbTestReadCool3_ctest (Failed)
	 50 - IOVDbTestAlg_IOVDbTestReadCoolWriteMD_ctest (Failed)
	 51 - IOVDbTestAlg_IOVDbTestReadCoolFromMD_ctest (Failed)
	 53 - IOVDbTestAlg_IOVDbTestAlgReadCoolAfterTwoStep_ctest (Failed)
	1072 - LArConditionsTest_LArConditionsTestReadNoReg_ctest (Failed)

added review-user-action-required label and removed review-pending-level-1 label

marked this merge request as draft

added 1 commit

• 57d3584f - Fix some tests for conditions, which need to be stored in seperate trees.

Compare with previous version

marked this merge request as ready

Thanks Frank, the new commit should address these failures (for conditions we need separate trees). Peter

This merge request affects 4 packages:

• AtlasTest/DatabaseTest/IOVDbTestAlg
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/AthenaPoolExample/AthenaPoolExampleAlgorithms
• Database/RegistrationServices

Affected files list will not be printed in this case

Adding @ssnyder ,@mnowak as watchers

added Test review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 57d3584f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27018]

The egammaValidation_ut_egammaARTJob_test_ctest seems unrelated to this (and didn't happen before), so it is probably fine. Does anyone object to running through the CI one more time to be sure? Tom - L1 shifter

hi @tneep , I agree, but running CI once more is probably the prudent thing to do. Thanks, Peter

Jenkins please retry a build

This merge request affects 4 packages:

• AtlasTest/DatabaseTest/IOVDbTestAlg
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/AthenaPoolExample/AthenaPoolExampleAlgorithms
• Database/RegistrationServices

Affected files list will not be printed in this case

Adding @ssnyder ,@mnowak as watchers

CI Result FAILURE (hash 57d3584f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27069]

Hi @tneep ,

this wasn't any better :(, but it looks as egammaValidation_ut_egammaARTJob_test_ctest also failed in: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7G8AthenaOpt/ARDOC_TestLog_2021-01-27T2101/Reconstruction_egamma_egammaValidation___egammaValidationConf__egammaValidationTest__m.html

and isn't caused by this MR. The Tracking tests didn't fail in the previous CI (and there were no changes to this MR since). Something going wrong with Eigen, I think Ed Moyse mentioned that today. Not this MR either.

Thanks, Peter

Yes I think that this is probably fine to be approved. I'll pass this on to L2 for the final decision. Tom - L1 shifter

added review-pending-level-2 label and removed review-pending-level-1 label

Thanks, @tneep. The MR looks good. Approving. [L2]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 24bd283d

added sweep:ignore label