Implementation of jFEX mapping framework for forward detector regions

Bitwise offline simulation software. This framework is essentially still fully disconnected from the rest of the ATLAS framework (it is slowly being integrated with some monitoring software).

Numerous changes required to implement the jFEX mapping for forward detector regions (i.e. above 2.5 eta).

This is an extension to existing code designed to perform a similar task for the barrel region and EMEC, but the forward region is far more complex so requires a little bit of array athletics.

There's also a small text cleanup for the eFEX mapping code in there.

@afaulkne @vasothil

This is a replacement MR for the failed MR (due to conflicts and GIT issues) here: !40246 (closed)

changed the description

mentioned in merge request !40246 (closed)

marked this merge request as ready

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @kwhalen ,@afaulkne as watchers

added Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 6b163e37)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27576]

added review-user-action-required label

removed review-pending-level-1 label

I just have one repeated comment about commented-out blocks of code. Apart from that, given the extent of the changes and their specialized nature I think we should push this to L2 before approving. -- L1

added 1 commit

• 3f1eece4 - Cleanup of commented code blocks.

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/L1CaloFEXToolInterfaces

Affected files list will not be printed in this case

Adding @kwhalen ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label