ATR-22733, moving the tau dRtt hypo into a generic combo hypo step

Closes ATR-22733

Add GenerateCombinedChainDefs.py, where TrigTauXComboHypoTool is now added to the end of chains it is configured in. Eventually, this will be replaced by a non-tau-specific hypo.

While implementing the functionality in the chainDict to trigger topo algs, I found a bug in DictFromChainName.py leftover from the python2.7 -> python3 conversion that caused unimplemented identifiers to not throw errors. Consequently, many people added chains where the identifiers were not in the allowed lists in SignatureDicts.py.

Also, a number of chains were added where the identifiers were not configurable at all (ivarloose muons, and one of the dijet hypos). These five chains have been commented out in the menu, with a comment as to why. The relevant people are aware. It should not be very long before they can be uncommented.

added 1 commit

• 6d9950f6 - Add new combined chain def file

Compare with previous version

added 1 commit

• cfc53b6f - Clean up some code

Compare with previous version

marked this merge request as ready

added 1 commit

• bc18d3d3 - Clean up some code

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added Tau Trigger TriggerMenu changes-trigger-counts master review-pending-level-1 labels

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

CI Result FAILURE (hash bc18d3d3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27636]

CI Result FAILURE (hash cfc53b6f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27637]

@fpastore there's an error in the full_menu_cf unit tests on the chain:

HLT_j0_vbenfSEP30etSEP34mass35SEP50fbet_L1J20

This is not a well-formed chain. vbenfSEP30etSEP34mass35SEP50fbet doesn't exist, it slipped through before because of the error in DictFromChainName.py.

Can I delete it? Or do you have something you want it replaced by? I'm not sure what you're trying to test with this chain, exactly.

edit: maybe I can replace it with a working chain like HLT_j0_aggSEP1000htSEP30etSEP0eta320_L1J20?

thanks!

added 1 commit

• 01029b90 - fix chain in full_menu_cf_test

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

Hi Heather, it was there for some old tests, it it’s obsolete you can remove it, for sure

added 1 commit

• a420386b - remove obsolete chain from full_menu_cf_test

Compare with previous version

resolved all threads

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

CI Result SUCCESS (hash 01029b90)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27667]

CI Result SUCCESS (hash a420386b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27670]

added 1 commit

• 7d92a4da - remove now unused group to get rid of make warning

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

CI Result SUCCESS (hash 7d92a4da)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27689]

Changes look good, discussion is finished and the warning seem urelated, approving (L1).

added review-approved label and removed review-pending-level-1 label

Hi @hrussell , please fix merge conflicts. Thanks!

added review-user-action-required label

added 323 commits

• 7d92a4da...a41e901f - 322 commits from branch atlas:master
• 633dcd04 - fix merge conflict in single line of imports

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@vmartin ,@okumura ,@carquin ,@dzanzi ,@bernius ,@hrussell ,@malconad as watchers

added review-pending-level-1 label and removed review-approved review-user-action-required labels

CI Result SUCCESS (hash 633dcd04)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27882]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5afee0f1

added sweep:ignore label