Skip to content
Snippets Groups Projects

Add Lxy cut and monitoring to TrigMultiTrkComboHypo

Merged Adam Edward Barton requested to merge abarton/athena:BLS_Lxy0 into master
All threads resolved!

We may need lxy0 triggers so I have added the ability to cut on lxy and added monitoring for lxy,

Decoration code will no longer be called during Dimu L2 trigger (since it wasn't used).

I now pass eventcontexts to the VKalVrt, this avoids a threadlocal lookup which can hurt performance.

Edited by Adam Edward Barton

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think I will separate the vertex and the TrigBphys creation. This way decoration code doesn't need to be pointlessly called in L2 mode.

  • added 1 commit

    • 59bfe4ce - Avoid creating TrigBphys in L2 and avoid threadlocal context lookup in VKalVrt

    Compare with previous version

  • Adam Edward Barton changed the description

    changed the description

  • Adam Edward Barton resolved all threads

    resolved all threads

  • Adam Edward Barton marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • Trigger/TrigHypothesis/TrigBphysHypo

    This merge request affects 8 files:

    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/python/TrigMultiTrkComboHypoMonitoringConfig.py
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigBmumuxComboHypo.cxx
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigBmumuxComboHypo.h
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigMultiTrkComboHypo.cxx
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigMultiTrkComboHypo.h
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigMultiTrkComboHypoTool.cxx
    • Trigger/TrigHypothesis/TrigBphysHypo/src/TrigMultiTrkComboHypoTool.h

    Adding @jakoubek ,@abarton as watchers

  • :white_check_mark: CI Result SUCCESS (hash 59bfe4ce)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27864]

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit b740ae86

  • Please register or sign in to reply
    Loading