Skip to content
Snippets Groups Projects

Fix partial event building and add stricter runtime checks

Merged Rafal Bielski requested to merge rbielski/athena:fix-peb into master

!39280 (merged) broke partial event buildings in two ways. !40260 (merged) fixed only one of the issues. This MR fixes the other one and makes runtime checks much stricter to ensure serious issues like this don't make it through CI and ART.

Changes:

  1. TriggerConfig.py: Build the list of PEBDecisionKeys from all hypo decisions and not just final decisions, because now PEB hypo is not final for a PEB chain (instead a ComboHypo is).
  2. StreamTagMakerTool: Fail if PEB information cannot be retrieved from the event store.
  3. StreamTagMakerTool: Fail if PEB information is retrieved but empty.
  4. TriggerEDMDeserialiserAlg: Fail if data payload is missing.
  5. trigbs_dumpHLTContentInBS_run3.py: Print event building information for stream tags when --stag option is used (helps debugging).
  6. TrigP1Test: Fix the PEB_DS and test configuration to properly define and test DataScouting chains and update the post-exec checks following the change to trigbs_dumpHLTContentInBS_run3.py. Also fix the timeout test configuration.
  7. TrigExPartialEB: Fix MTCalibPeb configuration to avoid failures on new checks in StreamTagMakerTool.

Fixes ATR-22585

Merge request reports

Pipeline #2296066 passed

Pipeline passed for a49a975e on rbielski:fix-peb

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 4 years ago (Feb 8, 2021 7:36pm UTC)

Merge details

  • Changes merged into master with 72a57966.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading