Fix partial event building and add stricter runtime checks
!39280 (merged) broke partial event buildings in two ways. !40260 (merged) fixed only one of the issues. This MR fixes the other one and makes runtime checks much stricter to ensure serious issues like this don't make it through CI and ART.
Changes:
-
TriggerConfig.py
: Build the list ofPEBDecisionKeys
from all hypo decisions and not just final decisions, because now PEB hypo is not final for a PEB chain (instead a ComboHypo is). -
StreamTagMakerTool
: Fail if PEB information cannot be retrieved from the event store. -
StreamTagMakerTool
: Fail if PEB information is retrieved but empty. -
TriggerEDMDeserialiserAlg
: Fail if data payload is missing. -
trigbs_dumpHLTContentInBS_run3.py
: Print event building information for stream tags when--stag
option is used (helps debugging). - TrigP1Test: Fix the PEB_DS and test configuration to properly define and test DataScouting chains and update the post-exec checks following the change to
trigbs_dumpHLTContentInBS_run3.py
. Also fix the timeout test configuration. - TrigExPartialEB: Fix MTCalibPeb configuration to avoid failures on new checks in
StreamTagMakerTool
.
Fixes ATR-22585
Merge request reports
Activity
This merge request affects 5 packages:
- HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
- Trigger/TrigSteer/TrigOutputHandling
- Trigger/TrigTools/TrigByteStreamTools
- Trigger/TrigValidation/TrigP1Test
- Trigger/TriggerCommon/TriggerJobOpts
Affected files list will not be printed in this case
Adding @salderwe ,@vmartin ,@okumura ,@wiedenma ,@bernius ,@tamartin ,@fwinkl ,@rbielski as watchers
added Trigger master review-pending-level-1 labels
CI Result FAILURE (hash 1091b80f)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27752]added 6 commits
-
1091b80f...4882b1c2 - 5 commits from branch
atlas:master
- a49a975e - Fix partial event building and add stricter runtime checks
-
1091b80f...4882b1c2 - 5 commits from branch
This merge request affects 5 packages:
- HLT/Trigger/TrigControl/TrigExamples/TrigExPartialEB
- Trigger/TrigSteer/TrigOutputHandling
- Trigger/TrigTools/TrigByteStreamTools
- Trigger/TrigValidation/TrigP1Test
- Trigger/TriggerCommon/TriggerJobOpts
Affected files list will not be printed in this case
Adding @salderwe ,@vmartin ,@okumura ,@wiedenma ,@bernius ,@tamartin ,@fwinkl ,@rbielski as watchers
CI Result SUCCESS (hash a49a975e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 27790]added review-approved label and removed review-pending-level-1 label
mentioned in commit 72a57966
added sweep:ignore label