Skip to content

[ATR-19768] Implementing a consistent naming scheme for HLT menu configuration modules across signatures

Teng Jian Khoo requested to merge khoo/athena:master-HLTMenu-pynaming into master

Addresses ATR-19768 by renaming python files and adjusting imports as needed.

Will provide an update to atlassoftwaredocs in parallel.

Also in the process simplified some of the import statements using relative paths where possible. As there aren't (yet) any very explicit guidelines for how to organise the code, nothing is imposed on the signature subfolders other than what was already there, i.e.:

  • [Signature]ChainConfiguration object is now defined in [Signature]ChainConfiguration.py instead of [Signature]Def.py
  • [Signature]RecoSequences.py is where reconstruction sequences should be defined (changed from [Signature]Setup.py
  • Functions returning MenuSequence go in [Signature]MenuSequences.py, but in some cases (notably egamma) are in other modules ending in "MenuSequences.py"
  • The files in CommonSequences don't exactly follow the convention, but were renamed to just be called [X]Sequences, and still remain fairly intuitive.

Merging this may need some attention from the RC, in case the changes conflict with MRs from signature developers.

Edited by Teng Jian Khoo

Merge request reports