Skip to content
Snippets Groups Projects

Fixes b-tagging filling of SV1_NGTinSvx in BTagLightSecVertexing.cxx (AFT-526)

All threads resolved!

This b-tagging MR fixes the number of good track for SV1 which was always zero in BTagLightSecVertexing.cxx. This is affecting the current evaluation of MV2c10/DL1(r) since SV1_NGTinSvx is also used in these taggers. The ticket corresponds to AFT-526.

Tagging: @vdao @cschiavi @sanmay @dguest @fdibello @rateixei

Edited by Arnaud Duperrin

Merge request reports

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 4 years ago (Feb 11, 2021 7:09pm UTC)

Merge details

  • Changes merged into master with c1f53d91.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Guest
  • added 1 commit

    • 3df05698 - small update to reduce the scope of the if statement for myVertexInfoVKal

    Compare with previous version

  • added bugfix label

  • Dan Guest resolved all threads

    resolved all threads

  • Arnaud Duperrin marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

    This merge request affects 1 file:

    • PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging/src/BTagLightSecVertexing.cxx

    Adding @dguest ,@cvarni ,@guirriec ,@lidiaz as watchers

  • Louis-Guillaume Gagnon resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 3df05698)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28046]

  • Note that this should be merged in before our trigger tuning MC request (ATR-22627) goes through.

    Edited by Dan Guest
  • Vakhtang Tsulaia
  • Vakhtang Tsulaia resolved all threads

    resolved all threads

  • mentioned in commit c1f53d91

  • Please register or sign in to reply
    Loading