Fix const correctness in codes related to HepMC (small MR)

Fix const correctness in codes related to HepMC. The changes will reduce the number of warnings in the nightlies by ~10.

marked this merge request as draft

This merge request affects 6 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

added Analysis Generators JetEtmiss LAr MuonSpectrometer Simulation master review-pending-level-1 labels

CI Result FAILURE (hash e9ffbc8b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 2, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28003]

removed review-pending-level-1 label

added 1 commit

• 25eef37e - Update GenVertexParticleAssociationTool.h

Compare with previous version

added 107 commits

• 25eef37e...9f4b6f31 - 105 commits from branch atlas:master
• 379195ec - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_10022021_part_3
• 4b2d23bb - Merge branch 'hepmc3_nightly_fixes_10022021_part_3' of...

Compare with previous version

marked this merge request as ready

This merge request affects 6 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

added review-pending-level-1 label

changed the description

removed review-pending-level-1 label

CI Result FAILURE (hash 4b2d23bb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28072]

added review-pending-level-1 label

added 76 commits

• 4b2d23bb...2b1f3dbf - 75 commits from branch atlas:master
• cc171fc3 - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_10022021_part_3

Compare with previous version

This merge request affects 5 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

added 23 commits

• cc171fc3...282c29d9 - 22 commits from branch atlas:master
• 1e0b3e36 - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_10022021_part_3

Compare with previous version

This merge request affects 5 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

added 1 commit

• 32c323fc - Fix for one broken case

Compare with previous version

This merge request affects 5 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

added 1 commit

• c13bd8b2 - Fix

Compare with previous version

This merge request affects 5 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

CI Result FAILURE (hash cc171fc3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28107]

CI Result FAILURE (hash 1e0b3e36)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28112]

CI Result FAILURE (hash 32c323fc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28113]

CI Result FAILURE (hash c13bd8b2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28118]

Latest build failing with:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/TruthParticleID/McParticleTools/src/PileupFilterTool.cxx: In member function 'StatusCode PileupFilterTool::rebuildLinks(const HepMC::GenEvent*, HepMC::GenEvent*, HepMC::GenParticlePtr)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/TruthParticleID/McParticleTools/src/PileupFilterTool.cxx:537:91: error: passing 'const HepMC::GenVertex' as 'this' argument discards qualifiers [-fpermissive]
   const HepMC::GenVertex::vertex_iterator endVtx = dcyVtx->vertices_end(HepMC::descendants);

-- L1

added review-user-action-required label and removed review-pending-level-1 label

added 82 commits

• c13bd8b2...3cff26a7 - 79 commits from branch atlas:master
• abbac1aa - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_10022021_part_3
• a15bdacb - Merge remote-tracking branch 'upstream/master' into hepmc3_nightly_fixes_10022021_part_3
• 03ec9e52 - Fix

Compare with previous version

removed review-user-action-required label

added review-pending-level-1 review-user-action-required labels

removed review-user-action-required label

This merge request affects 5 packages:

• Generators/AtlasHepMC
• LArCalorimeter/LArG4/LArG4Validation
• MuonSpectrometer/MuonTruthAlgs
• PhysicsAnalysis/TruthParticleID/McParticleTools
• Simulation/Tools/McEventCollectionFilter

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@pavol ,@nkoehler ,@jojungge as watchers

Hi @lgagnon ,

should be fixed now.

Best regards,

Andrii

resolved all threads

Jenkins please retry a build

CI Result SUCCESS (hash 03ec9e52)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28181]

changed title from Fix const correctness in codes related to HepMC to Fix const correctness in codes related to HepMC (small MR)

changed the description

MR looks good. Approving.

Abhishek [L2]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d6258159

added sweep:ignore label