Fix the HLT TimeBurner chain and prevent accepting events with unknown stream type
Fix the issue where HLT TimeBurner chain was accepting all events (to the stream unknown_DISCARD
) while it should be rejecting all. In addition, prevent such issues from happening by printing an error and returning failure in HLT output building if an event is accepted to any stream with unknown
type. This way an issue like this can be discovered in CI before its merged.
Changes (two separate commits):
- HLTResultMTByteStreamCnv: Fail if an event is accepted to stream with
unknown
type. cc @wiedenma - TriggerMenuMT+TrigGenericAlgs: Remove
comboHypoCfg=None
from step definition and create a reject decision object inTimeBurner::execute
. cc @tamartin
Closes ATR-22775
Merge request reports
Activity
added Trigger TriggerMenu master review-pending-level-1 labels
CI Result FAILURE (hash 0c94f141)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28035]added changes-trigger-counts label
added review-user-action-required label and removed review-pending-level-1 label
added 105 commits
-
0c94f141...9a17a881 - 103 commits from branch
atlas:master
- 9be2680e - Prevent events from being accepted into a stream with type
- 6aa9360d - Fix the TimeBurner chain
-
0c94f141...9a17a881 - 103 commits from branch
This merge request affects 4 packages:
- Trigger/TrigAlgorithms/TrigGenericAlgs
- Trigger/TrigSteer/TrigHLTResultByteStream
- Trigger/TrigValidation/TriggerTest
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @sutt ,@dzanzi ,@vmartin ,@okumura ,@bernius ,@tamartin ,@hrussell ,@rbielski as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 6aa9360d)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28059]added review-approved label and removed review-pending-level-1 label
mentioned in commit 457dd1b5
added sweep:ignore label