fix of ATLASRECTS-6019

!40462 (merged) resulted in ATLASRECTS-6019, which is being addressed here.

isGood function per FE used in !40462 (merged) could trigger a segfault. As a temporary solution per module alternative for FE status plots is being used for now. The other enabled FE plots are not affected. The function in question and subsequent function calls need more testing - the reason for the issue is not obvious.

added DQ InnerDetector bugfix master labels

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/PixelMonitoring

This merge request affects 1 file:

• InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthClusterMonAlg.cxx

Adding @goetz ,@stsuno ,@ibragimo ,@kzoch ,@lshan ,@battagl ,@sroe as watchers

added review-pending-level-1 label

added urgent label

This un-blocks hopefully the next round of large scale AthenaMT reco tests for the next weekend.

CI Result SUCCESS (hash b3f088e1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28051]

added review-approved label and removed review-pending-level-1 label

Hi all,

I had a fresh look at the conditions code (PixelConditionsSummaryTool) and it seems that isActive function I use in Monitoring as well can also cause troubles, just (unlike isGood I fixed) it is being protected by the information from condition database. So, depending on what is in the conditions tag, it can potentially create troubles, so I'd prefer disable that call as well to be 100% safe. I have an update, just running some quick test, then I can I push the changes. But this would delay the approval of this MR since CI will run for many hours. Should I do that here or open another MR?

No strong opinion - let's add your update in this MR - with incremental builds the CI will hopefully take not too long.

added 1 commit

• 7438237a - disabling FE status histograms

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetMonitoring/PixelMonitoring

This merge request affects 2 files:

• InnerDetector/InDetMonitoring/PixelMonitoring/python/PixelAthClusterMonAlgCfg.py
• InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthClusterMonAlg.cxx

Adding @goetz ,@stsuno ,@ibragimo ,@kzoch ,@lshan ,@battagl ,@sroe as watchers

added review-pending-level-1 label and removed review-approved label

OK, done. Thanks Johannes!

CI Result SUCCESS (hash 7438237a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28073]

removed review-pending-level-1 label

added review-approved review-pending-level-1 labels

removed review-pending-level-1 label

merged

mentioned in commit 87046bce

added sweep:ignore label