Remove skeleton.RDOtoRDOtriggerLegacy.py
The legacy RDOtoRDOTrigger transform has been disabled for a week since !40202 (merged) and it is now time to remove the unused code. Delete the legacy skeleton file and the script switching between MT and legacy, and rename the MT version to be the only RDOtoRDOTrigger skeleton. See also ATR-22725.
Changes:
Commit 1
git rm Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtriggerLegacy.py
git rm Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtrigger.py
git mv Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtriggerMT.py Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtrigger.py
Commit 2
Add the AthenaMT (threads >= 1) check. which was previously in the switching script, to the renamed MT skeleton. This is lines 15-20 in the updated file.
To reviewers: No new code is added and no code is changed except for the few lines from commit 2. This MR is only moving code around, but git always reports rm X
+ mv Y X
as if it was rm Y
+ modify X.
Merge request reports
Activity
This merge request affects 1 package:
- Reconstruction/RecJobTransforms
This merge request affects 3 files:
- Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtrigger.py
- Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtriggerLegacy.py
- Reconstruction/RecJobTransforms/share/skeleton.RDOtoRDOtriggerMT.py
Adding @goetz as watcher
added Reconstruction Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash ad613088)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28052]added review-approved label and removed review-pending-level-1 label
mentioned in commit 7efdd227
added sweep:ignore label