Skip to content
Snippets Groups Projects

L1 triggr menu Run2 to Run3 converter

Merged Joerg Stelzer requested to merge stelzer/athena:master-L1MenuXmlToJsonRun2 into master

For reprocessing of Run 2 data we translate the trigger configuration into the Run 3 format. This MR concludes ATR-22589

cc @tbold @tamartin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @stelzer

    I have added a couple of comments. Can you please have a look? Also, could you update the copyright notices to the current year. I saw you did it for some, but not for all files.

    Thanks, Volker (L1)

  • Joerg Stelzer resolved all threads

    resolved all threads

  • Joerg Stelzer added 1 commit

    added 1 commit

    • 3fa055ef - Address comment from code review

    Compare with previous version

  • Author Developer

    Hi @vaustrup

    thank you very much for your review. I have addressed all the comments.

    Cheers, Joerg

  • This merge request affects 3 packages:

    • Trigger/TrigConfiguration/TrigConfData
    • Trigger/TrigConfiguration/TrigConfIO
    • Trigger/TrigConfiguration/TrigConfStorage

    Affected files list will not be printed in this case

    Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

  • :white_check_mark: CI Result SUCCESS (hash 3fa055ef)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28150]

  • Louis-Guillaume Gagnon
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading