Update for actsv5.0.0
This MR update the Tracking/ACTS
to work with Actsv5.0.0 this will thus need to be merged after MR#810has been merged.
This also fix a segfault that started to occur in the material.
Merge request reports
Activity
added Tracking master review-pending-level-1 labels
mentioned in merge request atlasexternals!810 (merged)
CI Result FAILURE (hash ca82a4a7)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28168]@corentin The build fails with:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/Acts/ActsGeometry/src/util/ObjHelper.h:11:10: fatal error: Acts/Definitions/Algebra.hpp: No such file or directory #include "Acts/Definitions/Algebra.hpp"
Can you investigate? -- L1
added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Louis-Guillaume Gagnon
Hi @lgagnon has I mention in the description of the MR, this update the code to use Actsv5.0.0, currently the version of Acts used in ATLAS is v3.0.0 so obviously the build fail right now. This MR should be merged at the same time as MR810 which will increase the Acts version (if not when going from v3.0.0 to 5.0.0 almost everything in
Tracking/ACTS
will stop working).
removed review-user-action-required label
added review-pending-level-1 label
CI Result FAILURE (hash ca82a4a7)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28559]added review-user-action-required label and removed review-pending-level-1 label
Hi @vaustrup, I looked at the issue and apparently the CI run using Atlas external 2.0.100 instead of 2.0.101 (which contain the change to the Acts version). Rerunning the CI should fix this.
@corentin did you bump the externals version in this MR? This has to be done explicitly in a bunch of TXT files for the different projects.
Hi @pagessin I think I forgot that indeed. Let me have a look.
added 563 commits
-
ca82a4a7...2cf37305 - 561 commits from branch
atlas:master
- 3ce1ee42 - Merge remote-tracking branch 'upstream/master' into Acts5.0
- 273b42c2 - updated to external 2.0.101
-
ca82a4a7...2cf37305 - 561 commits from branch
This merge request affects 8 packages:
- Projects/AnalysisBase
- Projects/AthDataQuality
- Projects/AthGeneration
- Projects/AthSimulation
- Projects/Athena
- Projects/VP1Light
- Tracking/Acts/ActsGeometry
- Tracking/Acts/ActsPriVtxFinder
Affected files list will not be printed in this case
Adding @jchapman ,@amorley ,@akraszna ,@pagessin ,@krumnack ,@rbianchi as watchers
added Build review-pending-level-1 labels and removed review-user-action-required label
CI Result FAILURE (hash 273b42c2)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28732]added 1 commit
- 08b10af4 - updated ExtrapolatorComparisonTest in Tracking/TrkExtrapolation/TrkExAlgs
This merge request affects 9 packages:
- Projects/AnalysisBase
- Projects/AthDataQuality
- Projects/AthGeneration
- Projects/AthSimulation
- Projects/Athena
- Projects/VP1Light
- Tracking/Acts/ActsGeometry
- Tracking/Acts/ActsPriVtxFinder
- Tracking/TrkExtrapolation/TrkExAlgs
Affected files list will not be printed in this case
Adding @jchapman ,@amorley ,@akraszna ,@pagessin ,@krumnack ,@rbianchi as watchers
CI Result SUCCESS (hash 08b10af4)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28756]added review-approved label and removed review-pending-level-1 label
mentioned in commit 358c5811
added sweep:ignore label
mentioned in merge request !41494 (merged)