Skip to content
Snippets Groups Projects

Improving memory management in the radiation dmg code

Merged Improving memory management in the radiation dmg code
tdado/athena:RadDmgMemory into master
All threads resolved!
Merged Tomas Dado requested to merge tdado/athena:RadDmgMemory into master
All threads resolved!

This MR does not aim to improve the speed of the code, but it does three other things:

  • Deletes/closes files and histograms before event loop, once these are converted
  • Adds a protection to check if the correct files/histograms are read
  • Fixes one instance when the wrong type was read (TH3 vs TH2)

The results were cross-checked using diff-root wrt the code in master and no differences were found

cc @bnachman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak
  • Tomas Dado added 1 commit

    added 1 commit

    • a85856e3 - Using ROOT interface for retrieving of histograms

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • InnerDetector/InDetConditions/PixelConditionsAlgorithms
    • InnerDetector/InDetDigitization/PixelDigitization

    Affected files list will not be printed in this case

    Adding @goetz ,@jchapman ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 04ed02ff)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28256]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash a85856e3)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28259]

  • Louis-Guillaume Gagnon resolved all threads

    resolved all threads

  • Tadej Novak resolved all threads

    resolved all threads

  • P
    Pienpen Seema @pseema ·

    All threads are resolved and the code changes look fine, approving. Pienpen (L1)

  • Pienpen Seema added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Frank Winklmeier merged

    merged

  • Frank Winklmeier mentioned in commit d3523b89

    mentioned in commit d3523b89

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Shaun Roe
    Shaun Roe @sroe ·
    Developer

    Addresses ATLASRECTS-5883

    • Please register or sign in to reply