Skip to content
Snippets Groups Projects

CostAnalysis: fix missing event counts

Merged Aleksandra Poreba requested to merge aporeba/athena:cost-count-fix into master
All threads resolved!
  • resize x axis of Request_perEvent histogram in order to store all the counts
  • fix custom RunTrigCostAnalysis.py arguments - argument parser from ConfigFlags could not parse them

Example of table (with forceEnableAllChains, 100 events, weight=10):

https://atlas-trig-cost.cern.ch/?dir=aporeba&type=&tag=data18-13TeV&run=00000002&range=LumiBlock_00150&level=HLT&summary=ROS

Tagging @tamartin @mark

Merge request reports

Pipeline #2318481 passed

Pipeline passed for e09f07f4 on aporeba:cost-count-fix

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Feb 16, 2021 12:08pm UTC)

Merge details

  • Changes merged into master with c9ddd682 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Aleksandra Poreba resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 3f944df6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28271]

  • added 1 commit

    Compare with previous version

  • Aleksandra Poreba resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Trigger/TrigCost/TrigCostAnalysis

    This merge request affects 2 files:

    • Trigger/TrigCost/TrigCostAnalysis/share/RunTrigCostAnalysis.py
    • Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterROS.cxx

    Adding @tamartin as watcher

  • :white_check_mark: CI Result SUCCESS (hash e09f07f4)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28296]

  • All threads are resolved and the code changes look fine, approving. Pienpen(L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit c9ddd682

  • Please register or sign in to reply
    Loading