Skip to content
Snippets Groups Projects

Add MDTDigitVariables class to MuonPRDTest

Merged Add MDTDigitVariables class to MuonPRDTest
pajones/athena:master-mdt-digit-variables into master
All threads resolved!
Merged Paul Jones requested to merge pajones/athena:master-mdt-digit-variables into master
All threads resolved!

Added MDTDigitVariables class to MuonPRDTest to eventually validate HITStoRDO step for sMDT.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Koehler
  • Pienpen Seema added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Paul Jones added 1 commit

    added 1 commit

    • 8f6aad6d - Add MDTDigitVariables to NSWPRDValAlg

    Compare with previous version

  • Paul Jones resolved all threads

    resolved all threads

  • Paul Jones added 277 commits

    added 277 commits

    • 8f6aad6d...b9309ca6 - 276 commits from branch atlas:master
    • 1ceeece0 - Add MDTDigitVariables to NSWPRDValAlg and resolve merge conflicts

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonValidation/MuonPRDTest

    This merge request affects 5 files:

    • MuonSpectrometer/MuonValidation/MuonPRDTest/share/NSWPRDValAlg.digi.py
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/MDTDigitVariables.cxx
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/MDTDigitVariables.h
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/NSWPRDValAlg.cxx
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/NSWPRDValAlg.h

    Adding @rosati ,@wleight ,@jojungge ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Paul Jones resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1ceeece0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28681]

  • Nicolas Koehler
    Nicolas Koehler @nkoehler ·

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • MuonSpectrometer/MuonValidation/MuonPRDTest

    This merge request affects 5 files:

    • MuonSpectrometer/MuonValidation/MuonPRDTest/share/NSWPRDValAlg.digi.py
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/MDTDigitVariables.cxx
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/MDTDigitVariables.h
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/NSWPRDValAlg.cxx
    • MuonSpectrometer/MuonValidation/MuonPRDTest/src/NSWPRDValAlg.h

    Adding @rosati ,@wleight ,@jojungge ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1ceeece0)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28691]

  • M
    Mike Hance @mhance ·
    Developer

    Looks like this was already reviewed. Threads resolved, tests now pass. L1 approving.

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit d3fa0bd7

    mentioned in commit d3fa0bd7

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply