Skip to content
Snippets Groups Projects

Adding temporary way to correct for MM passivation

Merged Adding temporary way to correct for MM passivation
(removed):dev_alignment into master
All threads resolved!
Merged Stylianos Angelidakis requested to merge (removed):dev_alignment into master
All threads resolved!

Merge request reports

Approval is optional

Merged by Edward MoyseEdward Moyse 4 years ago (Feb 22, 2021 3:13pm UTC)

Merge details

  • Changes merged into master with e0243705 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Koehler
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Affected files list will not be printed in this case

    Adding @rosati ,@wleight ,@jojungge ,@nkoehler as watchers

  • ATLAS Robot added MuonSpectrometer master review-pending-level-1 labels

    added MuonSpectrometer master review-pending-level-1 labels

  • Stylianos Angelidakis added 1 commit

    added 1 commit

    • b8f2a84f - Adding temporary way to correct for MM passivation

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 8fda6534)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28534]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel
    • MuonSpectrometer/MuonReconstruction/MuonRecExample

    Affected files list will not be printed in this case

    Adding @goetz ,@rosati ,@wleight ,@jojungge ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash b8f2a84f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28568]

  • Mike Hance resolved all threads

    resolved all threads

  • Mike Hance added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • M
    Mike Hance @mhance ·
    Developer

    Changes look OK, tests pass, and comments seem to have been resolved. L1 approving.

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit e0243705

    mentioned in commit e0243705

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply