Porting 21.2 Isolation Variables and Selections

In order to use the updated object isolations for performance studies, several packages needed to be updated from 21.2 This MR cherry-picks all of the necessary commits in the following packages:

• Event/xAOD/xAODPrimitives
• InnerDetector/InDetRecTools/TrackVertexAssociationTool
• PhysicsAnalysis/AnalysisCommon/FsrUtils
• PhysicsAnalysis/AnalysisCommon/IsolationSelection
• Reconstruction/RecoAlgs/IsolationAlgs/
• Reconstruction/RecoTools/IsolationTool/

As I only attempted to bring these up to a specific moment in time and be as minimally invasive as possible to other packages, we do not have the most up-to-date commits, but these might be possible without too much trouble.

No new development was performed during these cherry-picks

added sweep:ignore label

This merge request affects 9 packages:

• Event/xAOD/xAODPrimitives
• InnerDetector/InDetRecTools/TrackVertexAssociationTool
• PhysicsAnalysis/AnalysisCommon/FsrUtils
• PhysicsAnalysis/AnalysisCommon/IsolationSelection
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
• Reconstruction/AODFix
• Reconstruction/RecoAlgs/IsolationAlgs
• Reconstruction/RecoTools/IsolationTool

Affected files list will not be printed in this case

Adding @dshope ,@fsforza ,@jojungge ,@markowen ,@oducu ,@mvanadia ,@maklein ,@nkoehler ,@goetz ,@amorley ,@yoyamagu ,@sroe ,@nakahama ,@szambito ,@akraszna ,@mhodgkin ,@gartoni as watchers

added 21.3 Analysis Derivation EDM Egamma InnerDetector JetEtmiss Reconstruction Trigger review-pending-level-1 labels

Jenkins please retry a build

added 1 commit

• 3c1be2cb - Fixing typo in deprecation warning.

Compare with previous version

This merge request affects 9 packages:

• Event/xAOD/xAODPrimitives
• InnerDetector/InDetRecTools/TrackVertexAssociationTool
• PhysicsAnalysis/AnalysisCommon/FsrUtils
• PhysicsAnalysis/AnalysisCommon/IsolationSelection
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
• Reconstruction/AODFix
• Reconstruction/RecoAlgs/IsolationAlgs
• Reconstruction/RecoTools/IsolationTool

Affected files list will not be printed in this case

Adding @dshope ,@fsforza ,@jojungge ,@markowen ,@oducu ,@mvanadia ,@maklein ,@nkoehler ,@goetz ,@amorley ,@yoyamagu ,@sroe ,@nakahama ,@szambito ,@akraszna ,@mhodgkin ,@gartoni as watchers

CI Result FAILURE (hash 6005c0ce)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 150
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28546]

CI Result FAILURE (hash 3c1be2cb)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 30
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28560]

@jchapman @okumura This merge request appears to be failing the tests for offline due to old isolation WPs (which are fixed here). Is there a policy that would impact the changes here? I think technically this violates frozen Tier0, but doesn't appear to impact the trigger counts.

added review-pending-expert label

removed review-pending-level-1 label

Pinging experts @jchapman and @okumura to make sure this MR is not forgotten -- L1

Sorry @bcarlson, @chhayes - I completely missed this. I'll restart the CI, just to check everything is still OK. @okumura is probably best placed to comment on the Trigger aspects though. :-)

Jenkins please try a build

Jenkins please retry a build

Hi @jchapman

We should try the build again one more time. I think @chhayes found in the CI check that the issue is the references use outdated isolation working points for offline... Ben

This merge request affects 9 packages:

• Event/xAOD/xAODPrimitives
• InnerDetector/InDetRecTools/TrackVertexAssociationTool
• PhysicsAnalysis/AnalysisCommon/FsrUtils
• PhysicsAnalysis/AnalysisCommon/IsolationSelection
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
• Reconstruction/AODFix
• Reconstruction/RecoAlgs/IsolationAlgs
• Reconstruction/RecoTools/IsolationTool

Affected files list will not be printed in this case

Adding @goetz ,@markowen ,@amorley ,@dshope ,@sroe ,@nakahama ,@fsforza ,@szambito ,@oducu ,@akraszna ,@mvanadia ,@maklein ,@jojungge ,@yoyamagu ,@gartoni ,@mhodgkin as watchers

added review-pending-level-1 label and removed review-pending-expert label

CI Result FAILURE (hash 3c1be2cb)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 150
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 29320]

Hello, the qTestsTier0_required-test is failing, please have a look into that. Thanks, Pienpen(L1)