correct names of the RDO collection in the MC mode, require one of the RDO/DC...

correct names of the RDO collection in the MC mode, require one of the RDO/DC collection to be present. a follow up the request of !40835 (merged) / ATR-22674

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@amorley ,@dzanzi ,@sutt ,@sroe ,@hrussell ,@bernius ,@goetz as watchers

added InnerDetector Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash 199479c1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28663]

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@amorley ,@dzanzi ,@sutt ,@sroe ,@hrussell ,@bernius ,@goetz as watchers

CI Result FAILURE (hash 199479c1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28701]

added 4 commits

• 199479c1...2cf37305 - 2 commits from branch atlas:master
• c7435ade - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into occupancy-fix-after-40835
• a8ff3691 - use empty key for DC to avoid the dependancy

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@calfayan ,@amorley ,@dzanzi ,@sutt ,@sroe ,@hrussell ,@bernius ,@goetz as watchers

CI Result FAILURE (hash a8ff3691)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28704]

mentioned in merge request !40835 (merged)

CI failures are likely unrelated, so maybe fixed in next build. Changes look fine, but there are a few threads to resolve, so sending back to user. -Mike (L1)

added review-user-action-required label and removed review-pending-level-1 label

Careful, CI failure is related - though due to a spam of INFO messages one has to go to the full 100Mb concatenated test logs.

Will open MR to remove some messages

RDOtoRDOTrigger 21:27:01 electronPrecisionInViewAlgs_GSF (1285), w/ decision: UNDEFINED(-1)
RDOtoRDOTrigger 21:27:01   precisionElectron_GSFprecisionElectron (1286), w/ decision: UNDEFINED(-1)
RDOtoRDOTrigger 21:27:01     PrecisionTrackViewDataVerifier_GSF (1287), w/ decision: TRUE(1), in state: EVTACCEPTED
RDOtoRDOTrigger 21:27:01     TrigEMBremCollectionBuilder (1288), w/ decision: UNDEFINED(-1), in state: CONTROLREADY
RDOtoRDOTrigger 21:27:01     ========
RDOtoRDOTrigger 21:27:01     missing data:  ( 'TRT_RDO_Container' , 'StoreGateSvc+TRT_RDOs' )
RDOtoRDOTrigger 21:27:01     required by tool: TrigEMBremCollectionBuilder.GSFBuildInDetTrigTrackSummaryTool
RDOtoRDOTrigger 21:27:01     can be produced by alg(s): ( FastTrackViewDataVerifier in state: INITIAL ) ( IDViewDataVerifier_bjet in state: INITIAL ) ( IDViewDataVerifier_bmumux in state: INITIAL ) ( IDViewDataVerifier_muonIso in state: INITIAL ) ( SGInputLoader in state: INITIAL ) ( muonCBViewDataVerifier_FS in state: INITIAL ) ( muonCBViewDataVerifier_RoI in state: INITIAL ) ( tauViewDataVerifier_tauIso in state: INITIAL ) ( tauViewDataVerifier_tauTau in state: INITIAL )
RDOtoRDOTrigger 21:27:01     data is available at whole-event level
RDOtoRDOTrigger 21:27:01     data is available in sub-slot(s) 14, 15, 16, entered from precisionEtcutInViewAlgs
RDOtoRDOTrigger 21:27:01     missing conditions data:  ( 'PixeldEdxData' , 'ConditionStore+PixeldEdxData' )
RDOtoRDOTrigger 21:27:01     required by tool: TrigEMBremCollectionBuilder.GSFBuildInDetTrigTrackSummaryTool
RDOtoRDOTrigger 21:27:01     current EventID: [300000,87473001,t:1500000000,l:1,b:2388]
RDOtoRDOTrigger 21:27:01     no interval(s) of validity

And indeed, the TRT_RDOs collection was not expressed to the scheduler by PrecisionTrackViewDataVerifier_GSF

RDOtoRDOTrigger 21:26:16   PrecisionTrackViewDataVerifier_GSF
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'CaloCellContainer' , 'StoreGateSvc+CaloCells' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'InDet::PixelGangedClusterAmbiguities' , 'StoreGateSvc+TrigPixelClusterAmbiguitiesMap' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'InDet::TRT_DriftCircleContainer' , 'StoreGateSvc+TRT_TrigDriftCircles' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'SG::AuxElement' , 'StoreGateSvc+EventInfo.AveIntPerXDecor' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'SG::AuxElement' , 'StoreGateSvc+EventInfo.averageInteractionsPerCrossing' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'SG::AuxVectorBase' , 'StoreGateSvc+CaloCells' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'SG::AuxVectorBase' , 'StoreGateSvc+HLT_CaloEMClusters' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'SG::AuxVectorBase' , 'StoreGateSvc+HLT_IDTrack_Electron_IDTrig' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'xAOD::CaloClusterContainer' , 'StoreGateSvc+HLT_CaloEMClusters' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+HLT_CaloEMClusters' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'xAOD::IParticleContainer' , 'StoreGateSvc+HLT_IDTrack_Electron_IDTrig' )
RDOtoRDOTrigger 21:26:16     o OUTPUT  ( 'xAOD::TrackParticleContainer' , 'StoreGateSvc+HLT_IDTrack_Electron_IDTrig' )

Which is what https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionTrackSequences.py#0038 was supposed to do? Not sure why this didn't get called?

added 1 commit

• 56bd0218 - update objects of ViewVerifyTrk_GSF

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@sutt ,@amorley ,@sroe ,@dzanzi ,@bernius ,@goetz ,@calfayan ,@hrussell as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 56bd0218)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28811]

Changes seem fine, tests now pass. @jmasik, if you're ready to proceed with approval, just resolve any open threads above. -Mike (L1)

added 1 commit

• 8d1a69c4 - escalate non-existing RDO container to ERROR

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@sutt ,@amorley ,@sroe ,@dzanzi ,@bernius ,@goetz ,@calfayan ,@hrussell as watchers

resolved all threads

added 1 commit

• ae70c8b8 - try to require one of the input container to be present

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@sutt ,@amorley ,@sroe ,@dzanzi ,@bernius ,@goetz ,@calfayan ,@hrussell as watchers

resolved all threads

added 1 commit

• ffb8e3cc - keep initialization of DC container as it was - required for overlay

Compare with previous version

This merge request affects 2 packages:

• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @cgrefe ,@sutt ,@amorley ,@sroe ,@dzanzi ,@bernius ,@goetz ,@calfayan ,@hrussell as watchers

CI Result SUCCESS (hash 8d1a69c4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28836]

CI Result FAILURE (hash ae70c8b8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28840]

15:56:22                                                   0      ERROR StoreGate/src/VarHandleKey.cxx:125 (StatusCode SG::VarHandleKey::initialize(bool)): code FAILURE: Cannot initialize a Read/Write/Update handle with a null key.
15:56:22 TRTOverlay.TRT_LocalOccupancy                     0      ERROR TRT_ElectronPidTools/src/TRT_LocalOccupancy.cxx:85 (StatusCode InDet::TRT_LocalOccupancy::initialize()): code FAILURE: m_trt_driftcircles.initialize(!m_isTrigger)

We should see this go away for the pipeline running from ffb8e3cc

resolved all threads

CI Result SUCCESS (hash ffb8e3cc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 28851]

resolved all threads

All threads are resolved, tests passed, the changes look fine, approving. Pienpen(L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 12358e93

added sweep:ignore label